Skip to content
This repository was archived by the owner on Apr 22, 2026. It is now read-only.
This repository was archived by the owner on Apr 22, 2026. It is now read-only.

event_list.has_schedule_activity_task_failed is not detecting ACTIVITY_TYPE_DOES_NOT_EXIST #20

Description

@saverchenkov

decisionTask.eventList.failed(activityId) returns false when this activityId is in fact failed.

I tried to trace the code through the debugger, and the way it is implemented right now, activityIdFor in event-list.js on line 19 receives scheduledEventId === undefined

screen shot 2014-03-06 at 3 48 32 pm
screen shot 2014-03-06 at 3 50 56 pm

I was able to fix this issue by doing this:

has_schedule_activity_task_failed: function (activityId) {
   return this._has_eventType_for_activityId(activityId, 'ScheduleActivityTaskFailed');
},

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions