Stock object serialization to disk logic and ToString logic is the same

[rakitaj]

Looking at the big picture, Stock is saved to a text file on disk using its ToString representation.

The serialization should be its own class or method, even if the to text file version calls Stock.ToString() at first.

[DanielOlewski]

What is a problem here then? Are you saying it's duplication? Or the methods don't live in the right place/class? (trying to understand the issue before the solution - per Eric's ask ...)

[rakitaj]

Good questions and thanks for asking. I think there is too much coupling between Stock and Form when looking at the save and load logic, it feels like the Save and Load logic is in the wrong place.

In terms of the single responsibility principle, the Form saves and loads the Stock objects. On save it depends on the implementation of Stock's ToString() method and its own logic and on load it depends on its logic and knowledge of the ordering of data in the string. I think Stock should provide its own methods for serialization & deserialization or delegate to a separate class.

Let me know what you think now?

[DanielOlewski]

The form also has something to do with the UI. I'd rather leave that to Form's responsibilities (more natural per name; well the name could use improvement too) and move everything else out. But back to what Eric wanted: focusing on listing the problems. I think the issues you listed is a good set. Let's see what others think before the fixing excercises start ...