fix(ingestion): commit every 25 rows in summaries and embeddings jobs#66
Merged
Conversation
Both jobs ran inside a single transaction — if the job failed or the server restarted mid-run, all progress was lost. Now commit every 25 rows so progress is durable. A failure at row 1500 preserves the first 1475 summaries/embeddings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both
run_generate_summaries_jobandrun_rebuild_embeddings_jobran inside a single database transaction. If the job failed at row 1500 of 1986, all 1500 summaries were lost.Fix:
conn.commit()every 25 rows (aligned with the existing progress logging interval).Impact
Test plan