yaws_config.erl:2071: ssl:cipher_suites/0 is deprecated and will be removed in OTP 24; use use cipher_suites/2,3 instead

[leoliu]

Compilation fails under OTP 23 with rebar3.

This is because of warnings_as_errors in erl_opts. Please consider remove warnings_as_errors which is a mistake. That flag only makes sense in development and does the wrong thing almost in every other situation, for example when pulled in as a dep.

[vinoski]

Yes, thanks, already working on it. Unfortunately this issue did not show up in the 23.0 release candidates, only in the 23.0 final release.

We've had the warnings_as_errors setting for years and it's not been a problem because we generally support the past five OTP releases, and so we test against all of them.

[leoliu]

Maybe consider only setting the flag when running tests. It keeps getting in the way.

[vinoski]

I just removed warnings_as_errors from rebar.config in 48686bb.

[leoliu]

Thanks a lot for the quick fix.

[slavamas]

sorry... it is still a problem regardless of rebar.
date
Thu Aug 13 23:40:19 PDT 2020
autoreconf -fi
.......
== yaws 2.0.7 ==

Configuration:
Application dir.: ${ERLANG_INSTALL_LIB_DIR}/yaws-${YAWS_VSN}

Prefix: /usr/local
etcdir: ${prefix}/etc
confdir: $(sysconfdir)/yaws
bindir: ${exec_prefix}/bin
vardir: ${prefix}/var
wwwdir: $(localstatedir)/yaws/www
appsdir: $(localstatedir)/yaws
logdir: $(localstatedir)/log/yaws
yawsdir: $(libdir)/yaws
docdir: ${datarootdir}/doc/${PACKAGE_TARNAME}
mandir: ${datarootdir}/man

Erlang root dir: /usr/lib/erlang
Erlang lib dir: /usr/lib/erlang/lib
Erlang compiler: /usr/bin/erlc
Erlang emulator: /usr/bin/erl
Windows Erlang emulator:
Erlang interpreter: /usr/bin/escript
Erlang dialyzer tool: /usr/bin/dialyzer
Erlang ct_run tool: /usr/bin/ct_run

yaws-yaws-2.0.7]$ make
Making all in src
make[1]: Entering directory /home/sm/yaws/zip/yaws-yaws-2.0.7/src' GEN ../ebin/yaws.app GEN ../ebin/yaws.appup ERLC ../ebin/yaws.beam ERLC ../ebin/yaws_app.beam ERLC ../ebin/yaws_ticker.beam ERLC ../ebin/yaws_config.beam compile: warnings being treated as errors yaws_config.erl:2071: ssl:cipher_suites/0 is deprecated and will be removed in OTP 24; use use cipher_suites/2,3 instead make[1]: *** [../ebin/yaws_config.beam] Error 1 make[1]: Leaving directory /home/sm/yaws/zip/yaws-yaws-2.0.7/src'
make: *** [all-recursive] Error 1

[slavamas]

erl
Erlang/OTP 23 [erts-11.0.3] [source] [64-bit] [smp:1:1] [ds:1:1:10] [async-threads:1] [hipe]

Eshell V11.0.3 (abort with ^G)

[slavamas]

uname -a
Linux cent7-16 3.10.0-1127.18.2.el7.x86_64 #1 SMP Sun Jul 26 15:27:06 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

[vinoski]

Run make all WARNINGS_AS_ERRORS= instead.

[slavamas]

Making all in src
make[1]: Entering directory /home/sm/yaws/zip/yaws-yaws-2.0.7/src' ERLC ../ebin/yaws_config.beam compile: warnings being treated as errors yaws_config.erl:2071: ssl:cipher_suites/0 is deprecated and will be removed in OTP 24; use use cipher_suites/2,3 instead make[1]: *** [../ebin/yaws_config.beam] Error 1 make[1]: Leaving directory /home/sm/yaws/zip/yaws-yaws-2.0.7/src'
make: *** [all-recursive] Error 1

[vinoski]

If you're trying to build from a 2.0.7 tarball or tag, it won't work. You need commit 28eecfd or newer.

[slavamas]

Hi, I actually go to this url: https://github.com/erlyaws/yaws/releases/tag/yaws-2.0.7 which says: Yaws 2.0.7 <https://github.com/erlyaws/yaws/releases/tag/yaws-2.0.7> [image: @vinoski] <https://github.com/vinoski> vinoski <https://github.com/vinoski> released this on Jul 14, 2019 · 25 commits <yaws-2.0.7...master> to master since this release version 2.0.7 yaws-2.0.7 <https://github.com/erlyaws/yaws/tree/yaws-2.0.7> c5aa1e3 <c5aa1e3> and I am obtaining zip source file there.

…

On Fri, Aug 14, 2020 at 9:10 AM Steve Vinoski ***@***.***> wrote: If you're trying to build from a 2.0.7 tarball or tag, it won't work. You need commit 28eecfd <28eecfd> or newer. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AELNG4KJLUETM4XOQ2WZTELSAVOYFANCNFSM4NASB3TA> .

[vinoski]

Yaws 2.0.7 was released over a year ago. It preceded Erlang/OTP version 23.0 by nearly a year. It therefore doesn't support 23.0 or newer. You can use version 22.x with Yaws 2.0.7.

If you require 23.0, then you will have to clone the Yaws repo and use it at commit 28eecfd or newer. Work on the next Yaws release, 2.0.8, is ongoing, and it'll include 23.0 support, but it's not yet ready.

[slavamas]

Hi Steve, I made the following changes and it compiles fine (well, one test fails, and I think, for the same reason, so, can be fixed the same way). src/yaws_config.erl %Ciphers = ssl:cipher_suites(), Ciphers = ssl:cipher_suites(all, 'tlsv1.3'), (line 2071) testsuite/dhfile_SUITE.erl ssl_with_valid_dhfile(Config) -> %SslOpts = [{ciphers, [C || {dhe_rsa, _, _}=C <- ssl:cipher_suites()]}], SslOpts = [{ciphers, [C || {dhe_rsa, _, _}=C <- ssl:cipher_suites(all, 'tlsv1.3')]}], ssl_with_invalid_dhfile(Config) -> %SslOpts = [{ciphers, [C || {dhe_rsa, _, _}=C <- ssl:cipher_suites()]}], SslOpts = [{ciphers, [C || {dhe_rsa, _, _}=C <- ssl:cipher_suites(all, 'tlsv1.3')]}],

…

On Fri, Aug 14, 2020 at 9:10 AM Steve Vinoski ***@***.***> wrote: If you're trying to build from a 2.0.7 tarball or tag, it won't work. You need commit 28eecfd <28eecfd> or newer. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AELNG4KJLUETM4XOQ2WZTELSAVOYFANCNFSM4NASB3TA> .

[slavamas]

I see. Thank you, Steve.

…

On Fri, Aug 14, 2020 at 9:52 AM Steve Vinoski ***@***.***> wrote: Yaws 2.0.7 was released over a year ago. It preceded Erlang/OTP version 23.0 by nearly a year. It therefore doesn't support 23.0 or newer. You can use version 22.x with Yaws 2.0.7. If you require 23.0, then you will have to clone the Yaws repo and use it at commit 28eecfd <28eecfd> or newer. Work on the next Yaws release, 2.0.8, is ongoing, and it'll include 23.0 support, but it's not yet ready. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#401 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AELNG4LQOMNQXUFSNB63RDTSAVTV7ANCNFSM4NASB3TA> .