Skip to content

Phabulous crash on Phriction (wiki) feed updates #80

@PaulJrBertucci

Description

@PaulJrBertucci

On Phriction updates appearing in Phabricator's webhooks feed, Phabulous panics and restarts. Presumably, the application doesn't know how to parse WIKI activity updates.

In debug mode, observed in the terminal:

DEBU[1163] epoch=1602018104&storyAuthorPHID=PHID-USER-cl7a2siedfznogpdf5dc&storyData%5BobjectPHID%5D=PHID-WIKI-cm3jfhzzz7prb5yiozb3&storyData%5BtransactionPHIDs%5D%5BPHID-XACT-WIKI-zgspd3oxsp2qygf%5D=PHID-XACT-WIKI-zgspd3oxsp2qygf&storyID=246&storyText=pbertucci+edited+the+content+of+Setup.&storyType=PhabricatorApplicationTransactionFeedStory

Immediately afterwards:

2020/10/06 21:01:44 [Recovery] panic recovered:
POST /v1/feed/receive HTTP/1.1
Host: localhost:8085
Accept: */*
Accept-Encoding: gzip
Content-Length: 333
Content-Type: application/x-www-form-urlencoded


runtime error: invalid memory address or nil pointer dereference
C:/Go/src/runtime/panic.go:491 (0x429c52)
C:/Go/src/runtime/panic.go:63 (0x428b5d)
C:/Go/src/runtime/signal_unix.go:367 (0x43ff2b)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/app/controllers/feed.go:56 (0x9e354e)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/app/controllers/feed.go:54 (0x9e354d)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/context.go:104 (0x9cf4b2)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/recovery.go:45 (0x9e0f99)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/context.go:104 (0x9cf4b2)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/logger.go:79 (0x9e03b0)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/context.go:104 (0x9cf4b2)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/gin.go:332 (0x9d7f03)
C:/Users/Martin/Documents/go/src/github.com/etcinit/phabulous/vendor/github.com/gin-gonic/gin/gin.go:296 (0x9d769a)
C:/Go/src/net/http/server.go:2619 (0x6d1573)
C:/Go/src/net/http/server.go:1801 (0x6cd6bc)
C:/Go/src/runtime/asm_amd64.s:2337 (0x457e70)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions