From 2e6d32400832addf7891f2587fadcdbcfd4a66ec Mon Sep 17 00:00:00 2001
From: winderica <winderica@gmail.com>
Date: Thu, 25 Jun 2026 00:40:30 +0800
Subject: [PATCH] Ensure challenges order consistency when creating replay
 transcript via `from` and `new`

---
 crates/primitives/src/transcripts/replay/mod.rs | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/crates/primitives/src/transcripts/replay/mod.rs b/crates/primitives/src/transcripts/replay/mod.rs
index 9c4e8197..5ba17791 100644
--- a/crates/primitives/src/transcripts/replay/mod.rs
+++ b/crates/primitives/src/transcripts/replay/mod.rs
@@ -20,9 +20,7 @@ pub struct ReplayTranscript<F> {
 
 impl<F: PrimeField, T: Transcript<F>> From<RecordingTranscript<F, T>> for ReplayTranscript<F> {
     fn from(value: RecordingTranscript<F, T>) -> Self {
-        Self {
-            cached_challenges: value.cached_challenges,
-        }
+        Self::new(value.cached_challenges)
     }
 }
 
@@ -58,9 +56,7 @@ impl<F: PrimeField, T: TranscriptGadget<F>> From<RecordingTranscriptVar<F, T>>
     for ReplayTranscriptVar<F>
 {
     fn from(value: RecordingTranscriptVar<F, T>) -> Self {
-        Self {
-            cached_challenges: value.cached_challenges,
-        }
+        Self::new(value.cached_challenges)
     }
 }
 
@@ -68,10 +64,7 @@ impl<F: PrimeField> TranscriptGadget<F> for ReplayTranscriptVar<F> {
     type Config = Vec<FpVar<F>>;
     type Widget = ReplayTranscript<F>;
 
-    fn new(mut cached_challenges: Vec<FpVar<F>>) -> Self
-    where
-        Self: Sized,
-    {
+    fn new(mut cached_challenges: Vec<FpVar<F>>) -> Self {
         cached_challenges.reverse();
         Self { cached_challenges }
     }