From 0df74b726ed223c487a6048555c2fe742ddab319 Mon Sep 17 00:00:00 2001 From: Derek Xu Date: Tue, 10 Mar 2026 05:00:39 -0700 Subject: [PATCH] fix: restore logging.basicConfig in test remote servers The revert in #434 accidentally removed the `logging.basicConfig(level=logging.INFO)` call from the test remote servers. Without it, the root logger defaults to WARNING, which silently drops the `logger.info()` call that emits `Status.rollout_finished()`. The FireworksTracingHttpHandler never fires, no POST /logs is made, and the RemoteRolloutProcessor polling loop times out after 180 seconds. This restores the original line (with its explanatory comment) in both remote_server.py and remote_server_multi_turn.py. Made-with: Cursor --- tests/remote_server/remote_server.py | 3 +++ tests/remote_server/remote_server_multi_turn.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/remote_server/remote_server.py b/tests/remote_server/remote_server.py index 4ac4fd6c..c7655671 100644 --- a/tests/remote_server/remote_server.py +++ b/tests/remote_server/remote_server.py @@ -13,6 +13,9 @@ app = FastAPI() +# Configure logging for the remote server (required for INFO-level logs to be emitted) +logging.basicConfig(level=logging.INFO, format="%(name)s - %(levelname)s - %(message)s") + # Attach Fireworks tracing handler to root logger fireworks_handler = FireworksTracingHttpHandler() logging.getLogger().addHandler(fireworks_handler) diff --git a/tests/remote_server/remote_server_multi_turn.py b/tests/remote_server/remote_server_multi_turn.py index 88815f09..971b6251 100644 --- a/tests/remote_server/remote_server_multi_turn.py +++ b/tests/remote_server/remote_server_multi_turn.py @@ -12,6 +12,9 @@ app = FastAPI() +# Configure logging for the remote server (required for INFO-level logs to be emitted) +logging.basicConfig(level=logging.INFO, format="%(name)s - %(levelname)s - %(message)s") + # Attach Fireworks tracing handler to root logger fireworks_handler = FireworksTracingHttpHandler() logging.getLogger().addHandler(fireworks_handler)