Not much safer warning

[k06a]

Hi, it seems your implementation is not MUCH safer than original, see this issue: johguse/profanity#61. Original profanity could be hacked in seconds/minutes with few hours of precompile. I suspect precompile table can be increased thousands of times algorithmically. Using 1000x bigger table and having 1000x more GPU core than average computer would allow to hack every 4000-th vanity address if I count correctly.

Consider calling rd() eight times in a row for achieving 256 bits of non-deterministic seed private key.

Or check out version of @1inch: https://github.com/1inch/profanity2 – it introduces “safety by design” by non-generating any private keys anymore, but finding shift for private key by provided public key of it.

[evmcheb]

Hey @k06a! Thanks for looking over the repo. I've added your suggested changes, and updated the README to point to 1inch's profanity2.

[k06a]

Hi @evmcheb BTW, I meant not to use mt19937_64 at all, because it adds nor safety, nor randomness :)

[jacklevin74]

@evmcheb -- wanted to see if this was fixed.. thanks!

[k06a]

@jacklevin74 you can use this version https://github.com/1inch/profanity2 to avoid any security concerns.