Skip to content

fix:update the supplier #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AadithPunathil merged 1 commit into from
Feb 23, 2026
Merged

fix:update the supplier #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 47 additions & 37 deletions calicut_textiles/calicut_textiles/doctype/supplier_packing_slip/supplier_packing_slip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,44 +33,54 @@ frappe.ui.form.on("Supplier Packing Slip", {
});
frappe.ui.form.on('Supplier Packing Slip Item', {
add: function(frm, cdt, cdn) {
var item = frappe.get_doc(cdt, cdn);

// validations
if (item.qty > item.po_actual_qty) {
frappe.msgprint(__('Quantity is more than in Actual Qty'));
return;
}

if (item.qty <= 0) {
frappe.msgprint(__('Quantity is zero, cannot add a new row.'));
return;
}

// calculate remaining qty
let remaining_qty = flt(item.po_actual_qty) - flt(item.qty);

// update current row first
frappe.model.set_value(cdt, cdn, 'po_remaining_qty', remaining_qty);

// -------- create new row (CORRECT WAY) ----------
let child = frappe.model.add_child(
frm.doc,
"Supplier Packing Slip Item", // Child Doctype name
"supplier_packing_slip_item" // Table fieldname
);

// populate new row
child.item_code = item.item_code;
child.qty = 0;
child.uom = item.uom;
child.po_ref = item.po_ref;
child.po_actual_qty = remaining_qty;
child.purchase_order_item = item.purchase_order_item;
child.lot_no = item.lot_no;

// refresh grid
frm.refresh_field('supplier_packing_slip_item');

let row = frappe.get_doc(cdt, cdn);

if (flt(row.qty) <= 0) {
frappe.msgprint(__('Quantity must be greater than zero.'));
return;
}

if (flt(row.qty) > flt(row.po_actual_qty)) {
frappe.msgprint(__('Quantity is more than Actual Qty.'));
return;
}

let remaining_qty = flt(row.po_actual_qty) - flt(row.qty);

frappe.model.set_value(cdt, cdn, 'po_remaining_qty', remaining_qty);

if (remaining_qty <= 0) {
frm.refresh_field('supplier_packing_slip_item');
return;
}

let table = frm.doc.supplier_packing_slip_item;
let current_index = table.findIndex(d => d.name === row.name);

// create row (adds at last)
let new_row = frm.add_child('supplier_packing_slip_item');

// populate values
new_row.item_code = row.item_code;
new_row.qty = 0;
new_row.uom = row.uom;
new_row.po_ref = row.po_ref;
new_row.po_actual_qty = remaining_qty;
new_row.po_remaining_qty = remaining_qty;
new_row.purchase_order_item = row.purchase_order_item;
new_row.lot_no = row.lot_no;

// remove from last position
table.splice(table.length - 1, 1);

// insert after current row
table.splice(current_index + 1, 0, new_row);

// reindex
table.forEach((d, i) => d.idx = i + 1);

frm.refresh_field('supplier_packing_slip_item');
},

qty: function(frm, cdt, cdn) {
Expand Down
Loading