Skip to content

DeskMooovement code review #83

@JamesESS

Description

@JamesESS
  • Contrast between text and background not great in places (navbar against pepper on homepage desktop view & search options against courgette)
  • Carousel getting out of alignment on desktop view
  • The month dropdown in my garden is really nice. The month's changing depending on selection is pretty cool I do think it woul be more intuitive if it stayed in calender order the whole time though.
  • Would be good if sign up with preexisting account threw error or just logged in assuming password matched
  • Dyanmic pages should 404 or something to that effect if no data available e.g. search/Apricot currently gives application error. (we need to do this too!)
  • I feel like the pumkins could do with taking up slightly less height on mobile view. using iphone 8 resolution it's not super clear there's more information below
  • Yuqing had issue where homepage searchbar wasn't visible in resized desktop view
  • Site looks fantastic! Mobile view is great
  • File structure is really neat (very jealous of this)
    Most of this is kinda nit picky overall it looks great
    xoxo gossip girl

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions