Installation failure with Torch 1.7

[chongxiaoc]

It looks like torch 1.7 moves the location of header file ATen/cuda/CUDAGeneratorImpl.h
Error:

[root@~/FBTT-Embedding #]/usr/local/cuda/bin/nvcc -I/usr/lib/python3.6/site-packages/torch/include -I/usr/lib/python3.6/site-packages/torch/include/torch/csrc/api/include -I/usr/lib/python3.6/site-packages/torch/include/TH -I/usr/lib/python3.6/site-packages/torch/include/THC -I/usr/local/cuda/include -I/usr/include/python3.6m -c tt_embeddings_cuda.cu -o build/temp.linux-x86_64-3.6/tt_embeddings_cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options '-fPIC' -O3 -g --expt-relaxed-constexpr -D__CUDA_NO_HALF_OPERATORS__ -I/usr/lib/cub-1.8.0 -gencode=arch=compute_70,code="sm_70" -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=tt_embeddings -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++14
tt_embeddings_cuda.cu:13:41: fatal error: ATen/cuda/CUDAGeneratorImpl.h: No such file or directory
 #include <ATen/cuda/CUDAGeneratorImpl.h>
                                         ^
compilation terminated.
error: command '/usr/local/cuda/bin/nvcc' failed with exit status 1

If I changed the location as below:

-#include <ATen/cuda/CUDAGeneratorImpl.h>
+#include <ATen/CUDAGeneratorImpl.h>

Installation completes.

[bilgeacun]

Thanks for the fix. Do you mind sending a pull request with the change?

[chongxiaoc]

@bilgeacun I would like to. But will this cause failure of building on Torch 1.6?
I assume you guys have tested torch 1.6 with existing code.

[bilgeacun]

We can bump the supported version to 1.7. Do you see any other problems with 1.7?

[chongxiaoc]

I run the benchmark on torch 1.7 and CUDA 11.2. It works so far.
Let me create a PR then.

[chongxiaoc]

PR drafted: #23

[bilgeacun]

Let me test DLRM to make sure that works as well.

[bilgeacun]

Actually I realized move of CUDAGeneratorImpl.h to ATen/cuda happened recently to support PT 1.11. So your change would be reverting that. See: pytorch/pytorch#70650

Can you try PT 1.11?

[chongxiaoc]

I see. But our production system doesn't support PT 1.11 by now.
I can close that PR then.
Thanks for clarification.