Skip to content

Fix KeyError crash in add_pending_resources on malformed squeue output#150

Merged
meta-codesync[bot] merged 1 commit into
facebookresearch:mainfrom
stephenacn:export-D105855425
May 22, 2026
Merged

Fix KeyError crash in add_pending_resources on malformed squeue output#150
meta-codesync[bot] merged 1 commit into
facebookresearch:mainfrom
stephenacn:export-D105855425

Conversation

@stephenacn

Copy link
Copy Markdown
Contributor

Summary: Handle empty fields from squeue

Reviewed By: calebho, luccabb

Differential Revision: D105855425

Summary: Handle empty fields from `squeue`

Reviewed By: calebho, luccabb

Differential Revision: D105855425
@meta-codesync

meta-codesync Bot commented May 21, 2026

Copy link
Copy Markdown

@stephenacn has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105855425.

@luccabb luccabb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions

Copy link
Copy Markdown

CI Commands

The following CI workflows run automatically on every push and pull request:

Workflow What it runs
GPU Cluster Monitoring Python CI lint, tests, typecheck, format, deb build, pyoxidizer builds
Go packages CI shelper tests, format, lint

The following commands can be used by maintainers to trigger additional tests that require access to secrets:

Command Description Requires approval?
/metaci tests Runs Meta internal integration tests (pytest) Yes — a maintainer must trigger the command and approve the deployment request
/metaci integration tests Same as above (alias) Yes

Note: Only repository maintainers (OWNER association) can trigger /metaci commands. After commenting the command, a maintainer must also navigate to the Actions tab and approve the deployment to the graph-api-access environment before the jobs will run. See the approval guidelines for what to approve or reject.

@meta-codesync meta-codesync Bot merged commit bd6bc59 into facebookresearch:main May 22, 2026
39 of 40 checks passed
@stephenacn stephenacn deleted the export-D105855425 branch May 22, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants