Fix KeyError crash in add_pending_resources on malformed squeue output#150
Merged
meta-codesync[bot] merged 1 commit intoMay 22, 2026
Merged
Conversation
Summary: Handle empty fields from `squeue` Reviewed By: calebho, luccabb Differential Revision: D105855425
|
@stephenacn has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105855425. |
luccabb
approved these changes
May 21, 2026
luccabb
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
CI CommandsThe following CI workflows run automatically on every push and pull request:
The following commands can be used by maintainers to trigger additional tests that require access to secrets:
|
luccabb
approved these changes
May 21, 2026
bd6bc59
into
facebookresearch:main
39 of 40 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Handle empty fields from
squeueReviewed By: calebho, luccabb
Differential Revision: D105855425