slurmprocessor: update collector dependencies to v0.153.0#152
Merged
Conversation
Update the slurmprocessor module's OpenTelemetry Collector library dependencies (go.opentelemetry.io/collector/*) from 0.126.0 / 1.32.0 to 0.153.0 (beta) / 1.59.0 (stable), and the go directive to 1.26.0. At the previous pin, `go mod tidy` fails resolving go.opentelemetry.io/otel/sdk/internal/internaltest, a transitive test package the current otel-go no longer provides. The 0.153.0 dependency set is self-consistent and resolves cleanly. No processor source changes were required; the component/processor/pdata APIs the processor uses are unchanged across these versions. The only code change is in the test: config_test.go used the collector's internal service/internal/testcomponents package (not importable across module boundaries) and now uses the public otelcoltest.NopFactories(), with testdata/config.yaml switched to the nop receiver/exporter to match. Verified: go mod tidy, go build ./..., go vet ./..., go test ./... pass.
CI CommandsThe following CI workflows run automatically on every push and pull request:
The following commands can be used by maintainers to trigger additional tests that require access to secrets:
|
tooji
approved these changes
Jun 4, 2026
|
@tooji has imported this pull request. If you are a Meta employee, you can view this in D107542218. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the slurmprocessor module's OpenTelemetry Collector library dependencies (go.opentelemetry.io/collector/*) from 0.126.0 / 1.32.0 to 0.153.0 (beta) / 1.59.0 (stable), and the go directive to 1.26.0.
At the previous pin,
go mod tidyfails resolving go.opentelemetry.io/otel/sdk/internal/internaltest, a transitive test package the current otel-go no longer provides. The 0.153.0 dependency set is self-consistent and resolves cleanly.No processor source changes were required; the component/processor/pdata APIs the processor uses are unchanged across these versions. The only code change is in the test: config_test.go used the collector's internal service/internal/testcomponents package (not importable across module boundaries) and now uses the public otelcoltest.NopFactories(), with testdata/config.yaml switched to the nop receiver/exporter to match.
Test Plan