Multiple requests crashing the server

[victorgluz]

Describe the bug
The bug happens when too many requests are fired at the same time, causing the server to restart.
I tried using asynchronous requests but there comes a time when it stops and also restarts the server.

Error log
The server has not responded for 10 seconds! Creating thread dump
[17:42:46 ERROR]: ------------------------------
[17:42:46 ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[17:42:46 ERROR]: ------------------------------
[17:42:46 ERROR]: Current Thread: Server thread
[17:42:46 ERROR]: PID: 36 | Suspended: false | Native: false | State: WAITING
[17:42:46 ERROR]: Stack:
[17:42:46 ERROR]: java.base@21.0.3/jdk.internal.misc.Unsafe.park(Native Method)
[17:42:46 ERROR]: java.base@21.0.3/java.util.concurrent.locks.LockSupport.park(LockSupport.java:371)
[17:42:46 ERROR]: java.base@21.0.3/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:519)
[17:42:46 ERROR]: java.base@21.0.3/java.util.concurrent.ForkJoinPool.unmanagedBlock(ForkJoinPool.java:3780)
[17:42:46 ERROR]: java.base@21.0.3/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3725)
[17:42:46 ERROR]: java.base@21.0.3/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1707)
[17:42:46 ERROR]: org.apache.http.pool.AbstractConnPool.getPoolEntryBlocking(AbstractConnPool.java:391)
[17:42:46 ERROR]: org.apache.http.pool.AbstractConnPool.access$300(AbstractConnPool.java:70)
[17:42:46 ERROR]: org.apache.http.pool.AbstractConnPool$2.get(AbstractConnPool.java:253)
[17:42:46 ERROR]: org.apache.http.pool.AbstractConnPool$2.get(AbstractConnPool.java:198)
[17:42:46 ERROR]: org.apache.http.impl.conn.PoolingHttpClientConnectionManager.leaseConnection(PoolingHttpClientConnectionManager.java:306)
[17:42:46 ERROR]: org.apache.http.impl.conn.PoolingHttpClientConnectionManager$1.get(PoolingHttpClientConnectionManager.java:282)
[17:42:46 ERROR]: org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:190)
[17:42:46 ERROR]: org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186)
[17:42:46 ERROR]: org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
[17:42:46 ERROR]: org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
[17:42:46 ERROR]: org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
[17:42:46 ERROR]: org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
[17:42:46 ERROR]: SkriptWebAPI-0.1.2.jar//com.google.api.client.http.apache.v2.ApacheHttpRequest.execute(ApacheHttpRequest.java:73)
[17:42:46 ERROR]: SkriptWebAPI-0.1.2.jar//com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1012)
[17:42:46 ERROR]: SkriptWebAPI-0.1.2.jar//dev.f2a.addon.skriptwebapi.elements.request.expressions.ExprWebRequest.get(ExprWebRequest.java:78)
[17:42:46 ERROR]: SkriptWebAPI-0.1.2.jar//dev.f2a.addon.skriptwebapi.elements.request.expressions.ExprWebRequest.get(ExprWebRequest.java:23)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.util.SimpleExpression.getArray(SimpleExpression.java:78)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.effects.EffChange.execute(EffChange.java:262)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.Effect.run(Effect.java:32)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:40)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:67)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.Trigger.execute(Trigger.java:33)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.command.ScriptCommand.execute2(ScriptCommand.java:333)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.command.ScriptCommand.lambda$execute$0(ScriptCommand.java:292)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.command.ScriptCommand$$Lambda/0x00007f013290ca88.run(Unknown Source)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.command.ScriptCommand.execute(ScriptCommand.java:303)
[17:42:46 ERROR]: Skript-2.10.0.jar//ch.njol.skript.command.ScriptCommand.onCommand(ScriptCommand.java:238)
[17:42:46 ERROR]: org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
[17:42:46 ERROR]: io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigCommand.run(BukkitCommandNode.java:91)
[17:42:46 ERROR]: com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73)
[17:42:46 ERROR]: net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:31)
[17:42:46 ERROR]: net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:19)
[17:42:46 ERROR]: net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8)
[17:42:46 ERROR]: net.minecraft.commands.execution.UnboundEntryAction$$Lambda/0x00007f0132a44668.execute(Unknown Source)
[17:42:46 ERROR]: net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5)
[17:42:46 ERROR]: net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:103)
[17:42:46 ERROR]: net.minecraft.commands.Commands.executeCommandInContext(Commands.java:443)
[17:42:46 ERROR]: net.minecraft.commands.Commands.performCommand(Commands.java:350)
[17:42:46 ERROR]: net.minecraft.commands.Commands.performCommand(Commands.java:337)
[17:42:46 ERROR]: net.minecraft.commands.Commands.performCommand(Commands.java:332)
[17:42:46 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2147)
[17:42:46 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$11(ServerGamePacketListenerImpl.java:2121)
[17:42:46 ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl$$Lambda/0x00007f0132a411a0.run(Unknown Source)
[17:42:46 ERROR]: net.minecraft.server.TickTask.run(TickTask.java:18)
[17:42:46 ERROR]: net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151)
[17:42:46 ERROR]: net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1537)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201)
[17:42:46 ERROR]: net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1514)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1507)
[17:42:46 ERROR]: net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1629)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1304)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:330)
[17:42:46 ERROR]: net.minecraft.server.MinecraftServer$$Lambda/0x00007f0130c72088.run(Unknown Source)
[17:42:46 ERROR]: java.base@21.0.3/java.lang.Thread.runWith(Thread.java:1596)
[17:42:46 ERROR]: java.base@21.0.3/java.lang.Thread.run(Thread.java:1583)

To Reproduce
Steps to reproduce the behavior:

1. Send multiple requests at the same time
2. Server is gone.

Expected behavior
I expect requests to receive a response, even if there is a delay in response time. And also that the server does not crash.

Screenshots
N.A.

Additional context
The problem also occurs on my local machine, which is a Ryzen 9 7900 with 24 Threads and 64Gb Ram, so I don't think the problem is memory or processor.

[victorgluz]

@fltuna

[fltuna]

Hello, victorgluz! Thank you for your report!

About synchronous web request syntax

Looks like your Skript code using synchronous web request syntax.
When using synchronous web request syntax in your code, for example:

command test:
    trigger:
        set {_request} to new http request with method "blah"
        set {_request}'s target url to "blah blah"
        # Web request will invoke and cause a lag spike
        set {_response} to response of {_request}
        
        # When web request is completed, we can use the response variable here
        set {_body} to body of {_response}
        broadcast "Body: %{_body}%"

This is expected behavior. Please use asynchronous request syntax instead.

Example:

command asyncget:
    trigger:
        set {_request} to new http request with method "GET"
        set {_request}'s target url to "https://httpbin.org/get"
        set {_request}'s header "Custom" to "Test"
        set {_request}'s header "Content-Type" to "application/json"
        set {_request}'s header "User-Agent" to "SkriptWebAPI/0.1.0"
        send async web request with {_request}

on web request response:
    set {_response} to event-httpresponse
    set {_body} to body of {_response}
    set {_method} to request method of {_response}
    broadcast "server: %{_response}'s header value from key "server"%"
    broadcast "1: %{_body}%"
    broadcast "2: %status code of {_response}%"
    broadcast "3: %request method of {_response}%"

When you using asynchronous web request syntax

If you're experiencing crashes while using async requests, please provide the following information:

• The Skript code that causes the crash (you can send just the request part)

About to adding feature

I don't plan to add inline async web request features, as I'm not actively maintaining this addon and have limited motivation for Minecraft development.

[victorgluz]

Hello, fltuna.

I am very grateful for your answer.

I will adapt the scripts to use asynchronous requests. When I finish, I will let you know if it worked.

Thank you very much.

[victorgluz]

Hi, @fltuna
After switching to async requests I created a new script with the on web request event:

on web request response:
	set {_response} to event-httpresponse
	set {_body} to body of {_response}
 	set {_method} to request method of {_response}
	set {_infos::*} to split {_body} at the delimiter "::"
	set {_player} to {_infos::2} parsed as a player
	if {_infos::1} is "rmc":
		send "&f[&b&lREDE&a&lMine&f]&r Você possui &b%{_infos::3}% RMC&r's!" to {_player}
	else if {_infos::1} is "purchase":

After some testing, even with asynchronous requests, the server always restarts after 10 requests.
Always 10 requests.
I have no idea what could be causing this. I've tried using Spigot, Paper and Purpur. They all have this problem.

[fltuna]

Sorry for late reply! I'm just woke up now!

First

First, can I have stack trace after using async request again?

Check lag spike with broadcasting debug message

Also, can you check what line causes a lag spike using broadcast "<text>" for example:

command asyncget:
    trigger:
        broadcast "Creating new HTTP request"
        set {_request} to new http request with method "GET"
        broadcast "Setting Target URL"
        set {_request}'s target url to "https://httpbin.org/get"
        broadcast "Sending request!"
        send async web request with {_request}
        broadcast "Request sent!"

on web request response:
    broadcast "Web request response received!"
    set {_response} to event-httpresponse
    broadcast "Obtaining body!"
    set {_body} to body of {_response}
    broadcast "Obtaining request method!"
    set {_method} to request method of {_response}