Scroll into view#1099
Open
wbazant wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1072
For me, this commit makes a difference between the keyboard impinging onto the field about third of the way and being fully visible. @ezwelty I'm definitely guessing and looking for cheap fixes here but would you try this one?
Also, I notice that the soft keyboard appearance also moves the image and tabs up, which is not possible with a normal scroll. It's a feature rather than bug. I had a go at a re-engineer of the location drawer
thinking it could be quite good for the full pane to behave like a normal website but it was unfortunately hard, not working, and I abandoned it.