[ts] Use choice type instead of Hungarian fields?

[aartaka]

So when I generate bindings for hl7.cda.uv.core@2.0.1-sd, I get this kind of interface with type-suffixed fields:

export interface SubstanceAdministration extends InfrastructureRoot {
    // ...
    effectiveTimeEIVL_TS?: EIVL_TS[];
    effectiveTimeIVL_TS?: IVL_TS[];
    effectiveTimePIVL_TS?: PIVL_TS[];
    effectiveTimeSXCM_TS?: SXCM_TS[];
    effectiveTimeSXPR_TS?: SXPR_TS[];
    // ...
}

Any motivation for that? Wouldn't union type work equally well here? Anything I'm missing?

[ryukzak]

Here is the overview of this decision: https://github.com/fhir-clj/type-schema/blob/main/docs/choice-type.md

The main reason why we have type-suffixed fields is historical. It looks like a good poke to have an alternative or option to generate ADT-like types here.