Merge pull request #65 from firstsun-dev/codex/perf-github-push-260723

Push boost

Author: ClaudiaFang

docs/push-strategy-benchmark.md

@@ -0,0 +1,25 @@
+# GitHub push strategy benchmark (#61)
+
+## Procedure
+
+Use a disposable repository and branch. For each file count (1, 5, 10, 25, 50, 100, 200), generate equal-size unique files, run the GraphQL path and then the developer-only `pushBatchViaGitDataApiForBenchmark` path on separate branches, and record the opt-in `PushTimingRecord` plus the REST wall time. Do not run this against a user vault or production branch.
+
+The GraphQL record is enabled only by registering `setPushTimingHandler`; it contains no file paths, contents, token, repository identity, or network transmission. `providerProcessingMs` is intentionally `null`, because Obsidian's `requestUrl` API does not expose server-only timing.
+
+## Deterministic request-count result
+
+| Files | GraphQL requests | Git Data API requests | Git Data API request waves (8 concurrent blobs) |
+| ---: | ---: | ---: | ---: |
+| 1 | 2 | 6 | 6 |
+| 5 | 2 | 10 | 6 |
+| 10 | 2 | 15 | 7 |
+| 25 | 2 | 30 | 9 |
+| 50 | 2 | 55 | 12 |
+| 100 | 2 | 105 | 18 |
+| 200 | 2 | 205 | 30 |
+
+GraphQL performs a branch-head read and one mutation; the caller marks the committed paths synced without a tree readback. Git Data API performs a ref read, commit read, one blob upload per file, tree creation, commit creation, and ref update. The table is covered by service tests for both implementations.
+
+## Decision
+
+Keep GraphQL as the production strategy for every supported batch size (1–200). There is no request-count crossover: Git Data API starts with four additional round trips and adds one request per file. The REST path remains developer-only so provider benchmarks can challenge this conclusion without adding a user-facing strategy switch.

feature_list.json

@@ -121,6 +121,22 @@
       "dependencies": ["feat-014"],
       "status": "done",
       "evidence": "Commit 7676325. npx eslint . -> 0 errors; npm run build -> clean; npx vitest run -> 344/344 passed."
+    },
+    {
+      "id": "feat-016",
+      "name": "perf(push): eliminate redundant GitHub requests + avoid stale rename lookup requests",
+      "description": "Two further push-speed perf commits landed on codex/perf-github-push-260723 before this session (pre-existing work, not authored in this session): 0445b17 eliminate redundant GitHub requests, f8a0a26 avoid stale rename lookup requests. perf(push) is patch-level under .releaserc.json's commit-analyzer, so these will bump 1.3.0 -> 1.3.1 on the next automated release.",
+      "dependencies": ["feat-015"],
+      "status": "done",
+      "evidence": "Commits 0445b17, f8a0a26 (pre-session)."
+    },
+    {
+      "id": "feat-017",
+      "name": "feat(i18n): localize update notifications (issue #64)",
+      "description": "The what's-new modal title/buttons were already i18n'd, but each release's entry text (src/changelog.ts) was hard-coded English. Restructured into src/changelog/ with one folder per version (1.2.1, 1.3.0, 1.3.1), each entry carrying inline {en, zh-tw, zh-cn} text resolved at render time by entryText() against the active locale (falls back to en). WhatsNewModal and the settings what's-new banner both switched from reading entry.text to entryText(entry). First pass put the text as new keys in the shared src/i18n/locales/*.ts catalog; user rejected that since it would make those files grow unbounded every release, so it was redesigned into the per-version-folder shape. Also added a 1.3.1 entry summarizing feat-016's push-speed work.",
+      "dependencies": [],
+      "status": "done",
+      "evidence": "npx eslint . -> 0 errors; npm run build -> clean; npx vitest run -> 351/351 passed."
     }
   ],
   "_evidenceStyle": "Keep evidence to one line: commit hash + short pointer (e.g. 'Commit abc1234 - added X, tests pass'). Debugging narrative and design discussion belong in the commit message, not this file."

package-lock.json

@@ -12,57 +12,55 @@ Completed work is archived in [archive/](./archive/), one file per calendar mont
 
 ## Current State
 
-**Last Updated:** 2026-07-14 12:05
+**Last Updated:** 2026-07-23
 **Session ID:** current
-**Active Feature:** None — feat-014 and feat-015 both committed. Ready for the next issue.
+**Active Feature:** feat-064 done. Ready for the next issue.
 
 ## Status
 
 ### What's Done
 
-- [x] feat-001..013 — see [archive/2026-07.md](./archive/2026-07.md)
-- [x] feat-014: GitHub's `pushBatch`/`deleteBatch` now use GraphQL `createCommitOnBranch` instead of the REST blob-per-file loop (commit `114a575`).
-- [x] feat-015: fixed a false "modified" status right after batch push, caused by GitHub's tree-by-branch-name read lagging a just-completed write. `pushAllFiles` now returns `syncedPaths`; `SyncStatusView` marks those files synced directly instead of re-fetching the remote tree (commit `7676325`).
-  - Both committed onto `claude/fix-directory-symlink-pull-260713`, **not yet pushed to remote**.
-  - Evidence: `npx eslint .` → 0 errors; `npm run build` → clean; `npx vitest run` → 344/344 passed.
+- [x] feat-001..015 — see [archive/2026-07.md](./archive/2026-07.md). 1.3.0 shipped 2026-07-14 (`chore(release): 1.3.0`).
+- [x] Two push-speed perf commits landed on `codex/perf-github-push-260723` prior to this session: `0445b17` (eliminate redundant GitHub requests) and `f8a0a26` (avoid stale rename lookup requests). Both `perf(push)` scope — patch-level under `.releaserc.json`'s commit-analyzer rules, so the next automated release will be 1.3.1.
+- [x] feat-064 (issue [#64](https://github.com/firstsun-dev/git-files-sync/issues/64)): "what's new" entry text moved out of hard-coded English strings. `ChangelogEntry.text` is now `{ en, 'zh-tw'?, 'zh-cn'? }`; `entryText()` in `src/changelog/index.ts` picks the active locale at render time, falling back to `en`. `WhatsNewModal` and the settings banner both call it instead of reading `entry.text` directly.
+- [x] Changelog content reorganized from a single growing `src/changelog.ts` into per-version folders (`src/changelog/1.2.1/`, `1.3.0/`, `1.3.1/`) — user explicitly asked for this instead of piling more keys into the shared `src/i18n/locales/*.ts` catalog, which would grow unbounded release over release.
+- [x] Added a `1.3.1` release entry (notable, i18n'd in en/zh-tw/zh-cn) summarizing the push-speed work, so the "what's new" modal covers it once semantic-release cuts 1.3.1.
+- Evidence: `npx eslint .` → 0 errors; `npm run build` → clean (includes Obsidian 1.11.0 compat check); `npx vitest run` → 351/351 passed. (Ran `npm install` first — `node_modules` was empty at session start in this worktree.)
 
 ### What's In Progress
 
 - Nothing actively in progress.
 
 ### What's Next
 
-1. Push `claude/fix-directory-symlink-pull-260713` to update PR #51 — confirm with the user first.
-2. Manually verify feat-014/feat-015 inside the actual Obsidian plugin UI (this session's verification used a live GitHub API smoke test driving `GitHubService` directly, not the full plugin).
-3. Filed issue #57 (repo `git-files-sync`, Project #6, P2, 4h estimate): build a repeatable live-credential smoke test process across GitHub/GitLab/Gitea, not just GitHub — https://github.com/firstsun-dev/git-files-sync/issues/57
-4. Re-sync against `gh issue list --repo firstsun-dev/git-files-sync --state open` — `feature_list.json`'s backlog is a snapshot from an earlier session.
-5. Issue #37 (Bitbucket provider support, feat-010): unblocked, still not started.
-6. PR #51 is large (10+ issues' worth of changes now). Flag to the user before piling on more commits.
+1. Push this session's commit to `origin/codex/perf-github-push-260723` — confirm with the user first (this branch already has no open PR; decide whether to open one or merge directly to `main`).
+2. New release folders (e.g. `src/changelog/1.4.0/`) still need one import line added to `src/changelog/index.ts`'s `CHANGELOG` array — not fully zero-touch, but no longer touches the shared i18n locale files.
+3. Re-sync against `gh issue list --repo firstsun-dev/git-files-sync --state open` — the backlog below is a snapshot from an earlier session.
 
 ## Blockers / Risks
 
 - None currently.
 
 ## Decisions Made
 
-- **All work goes into one PR (#51)**: user explicitly said "不要那麼多pr merge" (don't want so many PRs). Commit new work directly onto `claude/fix-directory-symlink-pull-260713`.
-- **Optimistic local status update over a post-push re-fetch (feat-015)**: rather than delaying the refresh or retrying, mark just-pushed files synced from data already in hand. Correct by construction (it's the exact content just written) and sidesteps GitHub's eventual-consistency window entirely instead of just narrowing it.
-- **Credential handling for live smoke tests**: write PATs to a local scratchpad file the agent reads directly — never as a `!`-prefixed command (still lands in the transcript) or a Bash argument (blocked by the permission classifier). Filed as issue #57 to build a proper reusable process across all three providers.
+- **Changelog "what's new" text lives in per-version folders under `src/changelog/`, not the shared i18n catalog**: user flagged that dumping every release's entry text into `src/i18n/locales/*.ts` would make those files grow forever. Each `src/changelog/<version>/index.ts` carries its own inline `{ en, zh-tw, zh-cn }` text; `src/changelog/index.ts` aggregates and resolves per the active locale via `entryText()`.
+- **perf → patch under `.releaserc.json`**: confirmed via `.releaserc.json`'s commit-analyzer `releaseRules` (`{ "type": "perf", "release": "patch" }`), so the two `perf(push)` commits already on this branch bump 1.3.0 → 1.3.1 automatically on release — no manual edit to `package.json`/`manifest.json`/`versions.json` (that's `@semantic-release/exec`'s job in CI).
 
 ## Files Modified This Session
 
-- `src/services/github-service.ts`, `src/services/git-service-base.ts`, `tests/services/github-service.test.ts` (feat-014)
-- `src/logic/sync-manager.ts`, `src/ui/SyncStatusView.ts`, `tests/logic/sync-manager-batch.test.ts`, `tests/ui/SyncStatusView.test.ts` (feat-015)
+- `src/changelog.ts` deleted; replaced by `src/changelog/{index,types}.ts` and `src/changelog/{1.2.1,1.3.0,1.3.1}/index.ts`
+- `src/ui/WhatsNewModal.ts`, `src/settings.ts` (use `entryText()` instead of raw `entry.text`)
+- `tests/changelog.test.ts`, `tests/ui/WhatsNewModal.test.ts` (fixtures updated to the new `text: { en }` shape)
+- `package-lock.json` (stale `version` field synced to 1.3.0 by `npm install`)
 
 ## Evidence of Completion
 
-- [x] Tests pass: `npx vitest run` → 344/344 passed
+- [x] Tests pass: `npx vitest run` → 351/351 passed
 - [x] Type check clean: `npm run build` → clean
 - [x] Lint clean: `npx eslint .` → 0 errors
-- [x] Live smoke tests against a real GitHub repo (feat-014 push/delete, feat-015 empty-file diagnosis)
-- [ ] Manual verification inside the actual Obsidian plugin UI — not yet done
+- [ ] Manual verification inside the actual Obsidian plugin UI — not done, no Obsidian instance available
 - [ ] Pushed to remote — not yet done, needs confirmation
 
 ## Notes for Next Session
 
-- Working branch: `claude/fix-directory-symlink-pull-260713` (PR #51). Commits `114a575` and `7676325` are local only — push before starting new work, or confirm with the user.
+- Working branch: `claude/conventional-perf-push-speed-9136c3`, tracking `origin/codex/perf-github-push-260723`. Nothing pushed yet — confirm with the user before pushing/merging.

progress.md

@@ -9,53 +9,49 @@
 
 ## Current Objective
 
-- Two fixes this session, both committed onto `claude/fix-directory-symlink-pull-260713` (PR #51), **not yet pushed to remote**:
-  1. **feat-014** (commit `114a575`): GitHub's `pushBatch`/`deleteBatch` switched from the REST Git Data API's per-file blob-creation loop to a single GraphQL `createCommitOnBranch` mutation.
-  2. **feat-015** (commit `7676325`): fixed a false "modified" status shown right after a batch push, caused by re-fetching the remote tree too soon after a write (GitHub's tree-by-branch-name read can lag a moment behind a just-completed commit).
+- Implement issue [#64](https://github.com/firstsun-dev/git-files-sync/issues/64) (localize "what's new" update notifications) on branch `claude/conventional-perf-push-speed-9136c3`, which tracks `origin/codex/perf-github-push-260723` (already ahead of `main` by two `perf(push)` commits: `0445b17`, `f8a0a26`). Also prepare the "what's new" changelog entry for the next patch release (1.3.1) covering those push-speed perf commits, so it's ready when semantic-release cuts the release. **Not yet committed or pushed.**
 
 ## Completed This Session
 
-- [x] `githubGraphQL()` helper in `github-service.ts`; explicit handling for GraphQL's 200-status-with-`errors`-array failure mode.
-- [x] `BaseGitService.getLatestCommitSha()` extracted from `resolveGitHubStyleBaseTree()`.
-- [x] `SyncManager.pushAllFiles()` now returns `syncedPaths: Array<{path, sha?}>`, populated at all three push-success sites (batch chunk, sequential fallback, immediate symlink/rename push).
-- [x] `SyncStatusView.executeBatchOperation()` marks just-pushed paths `'synced'` directly via a new `applyOptimisticSyncedStatus()` instead of calling `refreshAllStatuses()` after a push. Pull is unchanged (still does a full refresh).
-- [x] Live-verified both fixes against a real GitHub repo (`firstsun-dev/obsidian-sync-test`) using a scratchpad script that bundles the actual `github-service.ts` with a thin `obsidian` stub (`requestUrl` backed by real `fetch`) — not just mocks.
-- [x] Filed issue #57 on `firstsun-dev/git-files-sync` (Project #6, P2, 4h): build a repeatable live-credential smoke test process across GitHub/GitLab/Gitea (this session only covered GitHub).
-- [x] Cleaned up harness state: archived feat-011/012/013 + issue #78 fix + status-badge UI work into `archive/2026-07.md` (progress.md had grown past its own 80-line cleanup threshold); trimmed `feature_list.json` evidence strings under 300 chars. Harness self-audit went from 96/100 to 100/100.
+- [x] Refactored `src/changelog.ts` into a `src/changelog/` package: `types.ts` (shared interfaces), `index.ts` (aggregator + `entryText()` locale resolver + `getUnseenReleases()`), and one folder per release (`1.2.1/`, `1.3.0/`, `1.3.1/`) each exporting a `release: ChangelogRelease` with inline `{ en, 'zh-tw', 'zh-cn' }` text per entry.
+- [x] First design pass put the changelog text as new keys in the shared `src/i18n/locales/{en,zh-tw,zh-cn}.ts` catalog — **user rejected this** because it makes those files grow unbounded every release. Reverted and moved to the per-version-folder design above instead.
+- [x] `WhatsNewModal.ts` and `settings.ts` (the "what's new" banner) now call `entryText(entry)` to resolve text for the active locale (falls back to `en`) instead of reading a hard-coded `entry.text` string.
+- [x] Added a `1.3.1` release entry (notable, all three locales) describing the push-speed improvements, so the modal/banner will surface it once the next release ships.
+- [x] Updated `tests/changelog.test.ts` and `tests/ui/WhatsNewModal.test.ts` fixtures to the new `text: { en: '...' }` shape.
+- [x] `node_modules` was empty at session start in this worktree — ran `npm install` before the gate (this also fixed a stale `1.2.1` → `1.3.0` version mismatch in `package-lock.json`'s `"version"` field).
 
 ## Verification Evidence
 
 | Check | Command | Result | Notes |
 |---|---|---|---|
 | Lint | `npx eslint .` | 0 errors | |
 | Type check + compat | `npm run build` | Pass | Includes Obsidian 1.11.0 compat typecheck |
-| Tests | `npx vitest run` | 344/344 passed | +3 new: 2 for `syncedPaths`, 1 more for the post-push status behavior (total 5 new across both fixes) |
-| Live smoke test | ad-hoc scratchpad scripts | Pass | feat-014: pushBatch/deleteBatch each produced one commit with correct content. feat-015: single empty file and two-identical-empty-file batches both wrote correct 0-byte blobs with matching git shas — confirmed the bug was read-side (tree fetch timing), not write-side |
+| Tests | `npx vitest run` | 351/351 passed | |
 | Manual (in Obsidian) | — | Not done | No Obsidian instance available in this environment |
 
 ## Files Changed (this session)
 
-- feat-014: `src/services/github-service.ts`, `src/services/git-service-base.ts`, `tests/services/github-service.test.ts`
-- feat-015: `src/logic/sync-manager.ts`, `src/ui/SyncStatusView.ts`, `tests/logic/sync-manager-batch.test.ts`, `tests/ui/SyncStatusView.test.ts`
-- Harness state: `progress.md`, `session-handoff.md`, `feature_list.json`, `archive/2026-07.md`
+- `src/changelog.ts` deleted → `src/changelog/{index,types}.ts`, `src/changelog/{1.2.1,1.3.0,1.3.1}/index.ts`
+- `src/ui/WhatsNewModal.ts`, `src/settings.ts`
+- `tests/changelog.test.ts`, `tests/ui/WhatsNewModal.test.ts`
+- `package-lock.json` (version field sync from `npm install`)
 
 ## Decisions Made
 
-- **GraphQL only for GitHub**: GitLab's Commits API already sends a whole batch in one call; Gitea has no GraphQL API. `GitServiceInterface` stays REST-based elsewhere.
-- **Optimistic local status update over re-fetching (feat-015)**: use data already known from the push itself rather than trusting an immediate remote read, which sidesteps GitHub's eventual-consistency window rather than just narrowing it with a delay/retry.
-- **Credential handling**: PATs must go into a scratchpad file the agent reads directly (`fs.readFileSync`), never typed as a `!`-prefixed command (still lands in the transcript) or passed as a Bash command-line argument (blocked by the permission classifier as credential materialization). Filed issue #57 to formalize this as the only documented path for future provider testing.
+- **Per-version folders, not the shared i18n catalog**: see above — direct user correction mid-session.
+- **No manual version bump**: `.releaserc.json`'s commit-analyzer maps `perf` → `patch`, so 1.3.0 → 1.3.1 happens automatically via `@semantic-release/exec` in CI when this merges to `main`. Didn't hand-edit `package.json`/`manifest.json`/`versions.json`.
 
 ## Blockers / Risks
 
-- **Commits `114a575` and `7676325` are local only** — not pushed to `origin/claude/fix-directory-symlink-pull-260713` yet. Confirm with the user before pushing.
-- PR #51 keeps growing (10+ issues' worth now) — still worth flagging before adding more.
+- Nothing committed yet. Need to confirm with the user before committing and before pushing to `origin/codex/perf-github-push-260723` (shared branch, no open PR currently).
+- Whether the final destination is a PR against `main` or a direct merge of `codex/perf-github-push-260723` — not yet decided with the user.
 
 ## Next Session Startup
 
 1. Read `CLAUDE.md`, `feature_list.json`, `progress.md`, then this file.
-2. Run `./init.sh` before editing.
-3. Check whether `114a575`/`7676325` have been pushed yet (`git log origin/claude/fix-directory-symlink-pull-260713..HEAD`); push first if not, after confirming with the user.
+2. Run `./init.sh` (or at least `npm install`) before editing — this worktree started with an empty `node_modules`.
+3. Check `git log origin/codex/perf-github-push-260723..HEAD` — if this session's changelog work is still uncommitted/unpushed, finish that first.
 
 ## Recommended Next Step
 
-- Push this session's two commits, then either re-sync `gh issue list` or move to issue #37 (Bitbucket provider support) per the previously agreed order.
+- Commit the changelog work with a Conventional Commits message (likely `feat(i18n): localize update notifications` scope, closes #64), confirm with the user, then push to `origin/codex/perf-github-push-260723`.