Gurgle sound (quack)

[erlend-sh]

Description

https://freesound.org/people/Reitanna/sounds/252255/
https://freesound.org/people/Glaneur%20de%20sons/sounds/104949/
https://freesound.org/people/tim.kahn/sounds/103955/
https://freesound.org/people/vjoe1985/sounds/332658/
https://freesound.org/people/Kastenfrosch/sounds/113987/
https://freesound.org/people/FawfulGrox/sounds/103336/
https://freesound.org/people/LloydEvans09/sounds/221488/
https://freesound.org/people/isbeorn/sounds/553954/
https://freesound.org/people/brittmosel/sounds/529300/

We can keep it pretty low-key for the default key-press. You can however trigger a derpy kind of shriek by timing the gurgle together with an emote event #183

Alternatives & Prior Art

https://www.youtube.com/watch?v=_bmJpnhHlDs

[MaxCWhitehead]

One of the steps here will be adding a new button for triggering the glug sound.

This change is an example of how to add a new button and hooking it up: 2f684e6

[safa-amin]

Hello! I am writing on behalf of a team of software engineering students from Carnegie Mellon University in Qatar. For our Software Engineering class (17-313), we are tasked with contributing to an open-source project, and we are very excited about the possibility of contributing to Jumpy! We would be grateful if you could let us know whether our team can contribute to your project and, if so, how we can get started. Please feel free to reach out to me at sramin@andrew.cmu.edu or +974 55041045 if you’d like to discuss this further. We would really appreciate if you could get back to us. Thank you :))

[erlend-sh]

Sure! The basic recommendations for getting started are the same as here: #986 (comment)

Looking at how the player jump sound is setup would be a good reference for how audio is triggered.

See if you can find where the jump sound exists in our codebase; change it to a different sound to confirm. If you can’t locate it just ask us.

For the actual feature proposed here, two changes are required:

• a new button action; see Max’ comment above.
• that button action should trigger a sound; I suggest using this one since it doesn’t require any further audio editing.

We prefer keeping communications in the open, I.e. here on GitHub or on Discord.

[MaxCWhitehead]

On the note of adding a button (new key to trigger some action) - as can be seen in the comment @erlend-sh linked, it's a bit involved. The slide button is currently not actually used - referencing that diff, could also re-name this button to glug or gurgle and then add code to trigger sound based on that key.

[omjamnekar]

@erlend-sh @MaxCWhitehead Hey! Just checking if this issue is still open and available for contribution.

[erlend-sh]

Still open to contribution, but the project is on hiatus at the moment so there’s a chance your PR will remain pending for quite some time.

[gwenbradshaw]

Hi guys, i added the gurgle feature let my know if you like it!
#1054