`FluidTensorSlice::transpose()` should be marked `const`

[weefuzzy]

For const-correctness...

[tremblap]

I think this has been fixed:

flucoma-core/include/flucoma/data/FluidTensor.hpp

Lines 380 to 384 in 89d87be

	FluidTensorView<T, N> transpose() { return {mDesc.transpose(), data()}; }
	const FluidTensorView<const T, N> transpose() const
	{
	return {mDesc.transpose(), data()};
	}

and

flucoma-core/include/flucoma/data/FluidTensor.hpp

Lines 682 to 686 in 89d87be

	FluidTensorView<T, N> transpose() { return {mDesc.transpose(), mRef}; }
	const FluidTensorView<const T, N> transpose() const
	{
	return {mDesc.transpose(), mRef};
	}

[tremblap]

con(s)tinuing my education (ouch) this should be ok (r.e. the discussion on #311) except if the idea is to remove lines 682 and 380 to force them to always be const, or to add to those 2 lines a const after transpose() because it doesn't change the data.

[weefuzzy]

The latter

[tremblap]

ok good, incoming tomorrow!

[tremblap]

ok when I do

FluidTensorView<T, N> transpose() const { return {mDesc.transpose(), data()}; }

FluidTensorView<T, N> transpose() const { return {mDesc.transpose(), mRef}; }

I get loads of errors. Then I started to think: transpose() does modify the content of the object it is called on, so why should it be const?

[weefuzzy]

Durp, wasn't thinking. They can't both be marked const because then the compiler can't disambiguate them when called.