From 2575e6dcdc00453e4e9278390cdcf4395363b244 Mon Sep 17 00:00:00 2001 From: Owen Green Date: Wed, 25 Jun 2025 18:01:49 +0100 Subject: [PATCH 1/3] Update TestFluidTensor.cpp What is going on in the failing copy conversion test on windows? Add a console print in the hopes of getting a clue --- tests/data/TestFluidTensor.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/data/TestFluidTensor.cpp b/tests/data/TestFluidTensor.cpp index bcca9f07..228454e5 100644 --- a/tests/data/TestFluidTensor.cpp +++ b/tests/data/TestFluidTensor.cpp @@ -166,6 +166,9 @@ TEST_CASE("FluidTensor can be copied","[FluidTensor]"){ CHECK(y.cols() == x.cols()); CHECK(y.descriptor() == x.descriptor()); CHECK(std::equal(y.begin(),y.end(),x.begin())); + std::cout << "Copy Conversion Debug" << y << '\n' << x; + + } } From 86c4e7e27bacd96076ac1fdce3d8469984a18224 Mon Sep 17 00:00:00 2001 From: Owen Green Date: Wed, 25 Jun 2025 18:24:14 +0100 Subject: [PATCH 2/3] Update FluidTensor.hpp Weirdness in failing test, what's happening in this conversion constructor??? --- include/flucoma/data/FluidTensor.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/flucoma/data/FluidTensor.hpp b/include/flucoma/data/FluidTensor.hpp index 0b437df0..c0e85ccb 100644 --- a/include/flucoma/data/FluidTensor.hpp +++ b/include/flucoma/data/FluidTensor.hpp @@ -106,6 +106,7 @@ class FluidTensor //: public FluidTensorBase static_assert(std::is_convertible::value, "Cannot convert between container value types"); std::copy(x.begin(), x.end(), mContainer.begin()); + std::cout << "Debug failing test (value) \n" << x << '\n' << *this; } template @@ -117,6 +118,7 @@ class FluidTensor //: public FluidTensorBase "Cannot convert between container value types"); std::copy(x.begin(), x.end(), mContainer.begin()); + std::cout << "Debug failing test (view) \n" << x << '\n' << *this; } /// Conversion assignment From 050873ff1edf60d03acee253629ec446f50e7d0c Mon Sep 17 00:00:00 2001 From: Owen Green Date: Wed, 25 Jun 2025 19:05:21 +0100 Subject: [PATCH 3/3] Update TestFluidTensor.cpp Still chasing the weird --- tests/data/TestFluidTensor.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/data/TestFluidTensor.cpp b/tests/data/TestFluidTensor.cpp index 228454e5..2b1973bd 100644 --- a/tests/data/TestFluidTensor.cpp +++ b/tests/data/TestFluidTensor.cpp @@ -160,13 +160,14 @@ TEST_CASE("FluidTensor can be copied","[FluidTensor]"){ } SECTION("Copy conversion") { - const FluidTensor y(x); - CHECK(y.size() == x.size()); - CHECK(y.rows() == x.rows()); - CHECK(y.cols() == x.cols()); + const FluidTensor x2{{0,1,2,3,4},{5,6,7,8,9}}; + const FluidTensor y(x2); + CHECK(y.size() == x2.size()); + CHECK(y.rows() == x2.rows()); + CHECK(y.cols() == x2.cols()); CHECK(y.descriptor() == x.descriptor()); - CHECK(std::equal(y.begin(),y.end(),x.begin())); - std::cout << "Copy Conversion Debug" << y << '\n' << x; + CHECK(std::equal(y.begin(),y.end(),x2.begin())); + std::cout << "Copy Conversion Debug" << y << '\n' << x2; }