Get user by id doesnt work if user doesn't have enough rights

[andrejcermak]

Get user by id doesn't work if user doesn't have enough rights because of the first 2 lines

def find_by_id(id) cached_user = find { |user| user.id == id } return cached_user if cached_user
as it calls the list_all_users in the all function, so if the user doesn't have sufficient rights to list all users, this fails.

[geemus]

@andrejcermak Thanks for the detailed report. Any ideas on how we might fix or workaround this? (I haven't used openstack in years at this point, so I don't feel equipped to easily fix/test).

[andrejcermak]

IMO just deleting the 2 lines that handle the cached_user variable should be enough to prevent this happening.

[geemus]

I'm open to some kind of change, though I presume it was there for some reason/need. So maybe it could still be there, but fail more gracefully (and then presumably disable caching) rather than removing caching altogether?

[andrejcermak]

Is there any standardized way of handling errors in this project? I think an easy solution would be to try the cache call once, catch the exception and then disable the caching somehow.

[geemus]

@andrejcermak Yeah, my thought was similar. I don't think there is an existing pattern that matches this particularly well (or at least not one that comes to mind).