rfc: contributor guidelines

[taciturnaxolotl]

It might be worth it to try to adopt contributor guidelines similar to nixpkgs on how to structure commits and run formatting prior to merging. Curious y'all's thoughts on this @nullcubee and @blaze-developer.

I would be in favor of adopting the package: version -> version commit standard and also using kamadorueda/alejandra (though I don't have strong opinions on formatter, so if y'all like something else, I'm happy to use that)

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

[taciturnaxolotl]

we could also use the ci: change and docs: change formats

[zentag]

I was hoping for something like that. Speaking of nixpkgs, why don't we just add these frc packages to nixpkgs? Though I've been using nixos a while I'm still not that competent so this is a question purely out of curiosity.

[taciturnaxolotl]

Good question, honestly; I'm not entirely sure it would meet the Nixpkgs standard of having enough users to be useful, and it would also be a bit harder to update quickly. Beyond that though, it certainly could be possible

[nullcubee]

adding contributor guidelines is a great idea, honestly I’d be inclined to adopt most of the nixpkgs guidelines ourselves, as I am decently familiar with them

using kamadorueda/alejandra

We actually already have a formatter defined in the flake:

frc-nix/flake.nix

Line 51 in a49aa40

formatter = forEachPkgs (pkgs: pkgs.nixfmt-tree);

and I am a fan of using nixfmt personally, not that I’m saying we can’t change it if we want lol

adopting the package: version -> version commit standard

we could also use the ci: change and docs: change formats

I agree with this

why don't we just add these frc packages to nixpkgs?

I'm not entirely sure it would meet the Nixpkgs standard of having enough users to be useful, and it would also be a bit harder to update quickly.

This, but we also have some decently hacky workarounds and lots of binary packages, so I’m not sure it would live up to nixpkgs quality either.

Being able to update and merge stuff on our own terms is definitely a major positive too, since FRC has such little time in the season.

[taciturnaxolotl]

i'm used to nixfmt so i'm good with that!