private/public

[videlec]

In your examples/ folder you do call functions starting with underscore

• _bound_for_sigma_norm
• _candidate_integers_sigma
• _bound_for_rho_embeddings

If these are supposed to be called by users why making them start with an underscore?

Part of openjournals/joss-reviews#3996

[fredstro]

They are not intended to be used by end users but I include them in the "examples" files because they demonstrate the different parts that goes into the algorithm.
There are two separate intentions behind the examples, the first is for end users to see how to use the algorithms and the second is to demonstrate the bounds and the inner workings to make it easier to verify that the algorithm is working correctly (and as described in the paper).

[videlec]

Maybe you could add more comments in the notebook in order to distinguish what the user is supposed to use (ie the public API that we should use when writing code that depends on hilbertmodgroup) and what the curious researcher might find interesting about the implementation details.

[fredstro]

I think that's a good idea. What do you think about the following at the top. This is really all a "regular" end user is expected to use.

[videlec]

I like it. Thanks.