Overview
Hello guys!!! First of all congratulation on the amazing work you are doing here. We've been using frictionless specifications a lot and now this frictionless-ckan-mapper package because we're going to integrate some frictionless datasets into our own CKAN instance.
Following frictionless-ckan-mapper README.md documentation I've found a little typo and a reference to an invalid attribute in frictionless_to_ckan module. Also, I would like to take the opportunity to suggest a small modification in the pattern used during one frictionless_to_ckan importation example.
- Little typo: In CKAN => Frictionless the "ckan_dataset" dict created isn't used as a argument in converter.dataset(), instead ckan_dict is provided, providing the error below:
So, change "ckan_dict" to "ckan_dataset" solves the problem:
- Reference to an invalid attribute in frictionless_to_ckan module: In Frictionless => CKAN frictionless_to_ckan' has no attribute 'dataset'
I think the correct "package" attribute is shown in package(fddict), so change "dataset" to "package" solves the problem:
I would like to take the opportunity to suggest changing "f2c" to "converter" in this last example to follow the documentation pattern
Obs.: All suggestions are implemented in PR 47
Please preserve this line to notify @amercader (lead of this repository)
Overview
Hello guys!!! First of all congratulation on the amazing work you are doing here. We've been using frictionless specifications a lot and now this frictionless-ckan-mapper package because we're going to integrate some frictionless datasets into our own CKAN instance.
Following frictionless-ckan-mapper README.md documentation I've found a little typo and a reference to an invalid attribute in frictionless_to_ckan module. Also, I would like to take the opportunity to suggest a small modification in the pattern used during one frictionless_to_ckan importation example.
So, change "ckan_dict" to "ckan_dataset" solves the problem:
I think the correct "package" attribute is shown in package(fddict), so change "dataset" to "package" solves the problem:
I would like to take the opportunity to suggest changing "f2c" to "converter" in this last example to follow the documentation pattern
Obs.: All suggestions are implemented in PR 47
Please preserve this line to notify @amercader (lead of this repository)