Skip to content

Post-triage footer should check for code agent availability before suggesting /fs-code #460

Description

@fullsend-ai-retro

What happened

PR #53 added an action-hints footer to triage sufficient comments in scripts/post-triage.sh (lines 517–526) that unconditionally suggests /fs-code and /fs-code <instruction> as next steps. During review, ralphbean commented (Jul 8) that the footer should be conditional on the code agent being installed: "it would be good to do this too, conditionally only when the code agent is installed. We could try to check that in the post script, so that we don't suggest commands for an agent that isn't in place." The multi-agent review squad (waynesun09, Jul 13) independently flagged this as a MEDIUM finding. The PR author acknowledged the gap (Jul 15) but deferred it: "I think this is out of scope, we can open a followup issue as this involves exploring the config, dealing with defaults, etc." No follow-up issue was filed.

What could go better

In repositories that use fullsend for triage but do not have a code agent configured, the triage footer now suggests commands that will not work, creating a confusing user experience. Users would see /fs-code as a suggested next step, try it, and get no response or an error. This is a UX gap that was identified during review but has not been tracked for resolution.

Confidence: high. Both a human reviewer and the multi-agent squad independently identified this gap. The PR author agreed it is valid. The fix requires reading the repo's agent configuration (e.g., config.yaml) in the post-triage script to determine whether a code agent is available.

Proposed change

In scripts/post-triage.sh, modify the sufficient footer block (lines 517–526) to check whether a code agent is configured before appending the /fs-code action hints. The check could:

  1. Read the repo's config.yaml (or the equivalent agent configuration source) to determine whether a code agent entry exists.
  2. If a code agent is configured, append the current footer with /fs-code suggestions.
  3. If no code agent is configured, either omit the footer entirely or append a generic footer without /fs-code suggestions (e.g., just "This issue is ready for implementation").

The implementation needs to handle edge cases: missing config file, config file without an agents section, and the default agent configuration when no explicit config exists.

Validation criteria

After the change: (1) In repos with a code agent configured (like fullsend-ai/agents itself), the triage sufficient footer should still show /fs-code suggestions. (2) In repos without a code agent configured, the triage footer should not suggest /fs-code. This can be validated by running the post-triage script with a mock config that omits the code agent entry and verifying the footer content. A test case should be added to scripts/post-triage-test.sh covering both scenarios.


Generated by retro agent from #53

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions