Skip to content

This repo's own shim claims to be generated from a file that does not exist #7011

Description

@waynesun09

.github/workflows/fullsend.yaml opens with:

# This file is managed by fullsend. Do not edit it directly.
# Upstream: https://github.com/fullsend-ai/fullsend/blob/main/internal/scaffold/fullsend-repo/.github/workflows/fullsend.yaml

No such file exists. internal/scaffold/fullsend-repo/.github/workflows/ holds the per-org stage workflows (code.yml, dispatch.yml, review.yml, and so on). The per-repo shim template is internal/scaffold/fullsend-repo/templates/shim-per-repo.yaml.

So the header is wrong twice over: it points at a path that does not resolve, and it tells a reader not to edit a file that is in practice hand-maintained, since nothing regenerates it. This repo's shim can therefore drift from the template it is supposed to mirror, and nothing notices.

That drift is not hypothetical. #6959 adds run-name to the template so a follow-up run can be bound to its work item; without the same line here, that binding would have been permanently dead on this repository, because scaffold sync only reaches consumers. It was added by hand in that PR, along with a test that diffs the two.

Proposed change

Either point the header at templates/shim-per-repo.yaml and add a check that this file matches the rendered template, or drop the "managed by fullsend" claim and say plainly that it is maintained by hand alongside the template.

Validation criteria

A change to the shim template that is not mirrored here fails a check, or the header no longer claims a generator that does not exist.

Found while adding run-name to this file in #6959.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugcomponent/ciCI pipelines and checkscomponent/dispatchWorkflow dispatch and triggerspriority/lowNice to have, address when convenienttriagedTriaged but awaiting human prioritizationtype/choreMaintenance and housekeeping tasks

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions