Skip to content

Spaces in search query result in TypeError #8

@ericdrobinson

Description

@ericdrobinson

It is possible to have spaces in the search query. When run in a Node environment, at least, this results in a TypeError in makeRequest. It appears as though the makeUri method does not properly URIEncode the space character.

The same problem actually plagues an empty search query as well (e.g. searching tags only). This is because the empty string is replaced with a single space character (" "), which hits the same problem mentioned above.

I was able to bypass the empty search query issue locally by simply removing that space character and leaving it as the empty string (""). I am not sure if this works as expected or if it breaks something else that is expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions