Update package manager. Add support Arch-like distributions by et-nik · Pull Request #21 · gameap/gameapctl

et-nik · 2026-05-16T21:43:27Z

Closes #20

Copilot

Pull request overview

This PR refactors package-manager configuration into a shared embedded YAML loader and adds pacman-based support so Arch-like distributions (including CachyOS) can be detected and installed correctly, addressing issue #20.

Changes:

Add pacman package manager implementation and wire it into package-manager detection/selection (including fallback detection by pacman binary).
Introduce pkgconfig embedded YAML loader shared by apt/dnf/pacman, and migrate package configuration + tests to it.
Adjust service manager detection to prefer systemctl when available.

Reviewed changes

Copilot reviewed 20 out of 50 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/service/service.go	Prefer `systemctl` over `service`; simplify Load signature/flow
pkg/package_manager/yum.go	Reuse shared field keys when parsing yum output
pkg/package_manager/pkgconfig/config.go	New shared embedded YAML config loader (apt/dnf/pacman)
pkg/package_manager/pkgconfig/config_test.go	New tests for config merging/normalization and pacman configs
pkg/package_manager/pkgconfig/apt/README.md	Documentation for apt config hierarchy
pkg/package_manager/pkgconfig/apt/default.yaml	New apt default package mappings and install hooks
pkg/package_manager/pkgconfig/apt/default_arm64.yaml	New apt arm64 overrides
pkg/package_manager/pkgconfig/apt/debian.yaml	Debian-level apt overrides
pkg/package_manager/pkgconfig/apt/debian_6.yaml	Debian 6 overrides
pkg/package_manager/pkgconfig/apt/debian_7.yaml	Debian 7 overrides
pkg/package_manager/pkgconfig/apt/debian_8.yaml	Debian 8 overrides
pkg/package_manager/pkgconfig/apt/debian_9.yaml	Debian 9 overrides
pkg/package_manager/pkgconfig/apt/debian_10.yaml	Debian 10 overrides
pkg/package_manager/pkgconfig/apt/debian_11.yaml	Debian 11 overrides
pkg/package_manager/pkgconfig/apt/debian_12.yaml	Debian 12 overrides
pkg/package_manager/pkgconfig/apt/debian_13.yaml	Debian 13 overrides
pkg/package_manager/pkgconfig/apt/debian_sid.yaml	Debian sid overrides
pkg/package_manager/pkgconfig/apt/debian_duke.yaml	Debian codename override
pkg/package_manager/pkgconfig/apt/debian_forky.yaml	Debian codename override
pkg/package_manager/pkgconfig/apt/ubuntu.yaml	Ubuntu-level apt overrides
pkg/package_manager/pkgconfig/apt/ubuntu_12.04.yaml	Ubuntu 12.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_14.04.yaml	Ubuntu 14.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_16.04.yaml	Ubuntu 16.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_18.04.yaml	Ubuntu 18.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_20.04.yaml	Ubuntu 20.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_22.04.yaml	Ubuntu 22.04 overrides
pkg/package_manager/pkgconfig/apt/ubuntu_22.10.yaml	Ubuntu 22.10 overrides
pkg/package_manager/pkgconfig/dnf/README.md	Documentation for dnf config hierarchy
pkg/package_manager/pkgconfig/dnf/default.yaml	New dnf default package mappings and install hooks
pkg/package_manager/pkgconfig/dnf/centos_7.yaml	CentOS 7-specific overrides
pkg/package_manager/pkgconfig/dnf/centos_8.yaml	CentOS 8-specific overrides
pkg/package_manager/pkgconfig/dnf/centos_10.yaml	CentOS 10-specific overrides
pkg/package_manager/pkgconfig/dnf/fedora.yaml	Fedora-level overrides
pkg/package_manager/pkgconfig/dnf/rocky.yaml	Rocky-level overrides
pkg/package_manager/pkgconfig/pacman/README.md	Documentation for pacman config hierarchy
pkg/package_manager/pkgconfig/pacman/default.yaml	New pacman default package mappings and hooks
pkg/package_manager/extended.go	New shared “extended” wrapper for YAML-driven steps across managers
pkg/package_manager/apt_strategy.go	Extract apt-specific install/remove behaviors into a strategy
pkg/package_manager/apt_search.go	Move apt list search into main package_manager package; add shared field constants
pkg/package_manager/apt.go	Switch to shared pkgconfig loader and shared extended wrapper
pkg/package_manager/dnf.go	Switch to shared pkgconfig loader and shared extended wrapper
pkg/package_manager/dnf_internal_test.go	Update internal tests to use shared `extended` wrapper
pkg/package_manager/pacman.go	New pacman package manager implementation + extended wrapper hookup
pkg/package_manager/pacman_internal_test.go	Tests for pacman info parsing + extended pacman creation
pkg/package_manager/manager.go	Add Arch routing + pacman binary fallback detection
pkg/package_manager/env_path_unix.go	Switch env PATH collection to use shared pkgconfig loader
pkg/package_manager/const.go	Add Arch distribution constant passthrough
pkg/package_manager/dnf/dnf.go	Removed old per-manager YAML loader (migrated to pkgconfig)
pkg/package_manager/dnf/dnf_test.go	Removed old dnf loader tests (replaced by pkgconfig tests)
pkg/package_manager/apt/apt_test.go	Removed old apt loader tests (replaced by pkgconfig tests)

Comments suppressed due to low confidence (1)

pkg/package_manager/pkgconfig/config.go:63

buildCacheKey uses osinf.Distribution.String() as-is, but LoadPackages lowercases the distribution for file selection (and tests expect case-insensitive behavior). If callers pass Distribution: "CentOS" vs "centos", you’ll cache duplicate entries for the same effective config. Consider normalizing (e.g., strings.ToLower) the distribution (and possibly codename) inside the cache key too, so cache behavior matches the loader’s case-insensitive semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

et-nik · 2026-05-16T22:02:08Z

 		switch key {
 		case "PackageInfo":
 			info.Name = value
-		case "Architecture":
+		case fieldArchitecture:
 			info.Architecture = value
-		case "Version":
+		case fieldVersion:
 			info.Version = value
-		case "Size":
+		case fieldSize:
 			info.Size = value
-		case "Description":
+		case fieldDescription:
 			info.Description = value
 		case "Installed-Size":
 			size, err := strconv.Atoi(value)


et-nik · 2026-05-16T22:02:05Z

+
+	cmd.Env = os.Environ()
+
+	log.Println('\n', cmd.String())


et-nik · 2026-05-16T22:02:03Z

+
+	cmd.Env = os.Environ()
+
+	log.Println('\n', cmd.String())


et-nik · 2026-05-16T22:01:59Z

+
+	cmd.Env = os.Environ()
+
+	log.Println('\n', cmd.String())


coveralls · 2026-05-16T21:50:56Z

Coverage Report for CI Build 25974081021

Coverage decreased (-0.2%) to 11.623%

Details

Coverage decreased (-0.2%) from the base build.
Patch coverage: 533 uncovered changes across 9 files (173 of 706 lines covered, 24.5%).
3 coverage regressions across 2 files.

Uncovered Changes

File	Changed	Covered	%
pkg/package_manager/apt_strategy.go	231	0	0.0%
pkg/package_manager/extended.go	264	94	35.61%
pkg/package_manager/pacman.go	106	49	46.23%
pkg/package_manager/apt.go	43	0	0.0%
pkg/package_manager/apt_search.go	12	0	0.0%
pkg/package_manager/manager.go	8	0	0.0%
pkg/service/service.go	7	0	0.0%
pkg/package_manager/pkgconfig/config.go	25	22	88.0%
pkg/package_manager/env_path_unix.go	2	0	0.0%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
pkg/package_manager/apt.go	2	0.0%
pkg/package_manager/manager.go	1	0.0%

Coverage Stats


Relevant Lines:	13525
Covered Lines:	1572
Line Coverage:	11.62%
Coverage Strength:	10.51 hits per line

💛 - Coveralls

et-nik added 4 commits May 16, 2026 21:39

update apt and dnf package management

bf91fa9

fix

5950da3

add pacman package manager

3beb319

systemcmd and system command fixes

a905b80

et-nik requested a review from Copilot May 16, 2026 21:43

Copilot started reviewing on behalf of et-nik May 16, 2026 21:43 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

review fix

444c9cf

et-nik merged commit cd1b6e7 into main May 16, 2026
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update package manager. Add support Arch-like distributions#21

Update package manager. Add support Arch-like distributions#21
et-nik merged 5 commits into
mainfrom
linux-pm

et-nik commented May 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

et-nik May 16, 2026

Uh oh!

et-nik May 16, 2026

Uh oh!

et-nik May 16, 2026

Uh oh!

et-nik May 16, 2026

Uh oh!

coveralls commented May 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

et-nik commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

et-nik May 16, 2026

Choose a reason for hiding this comment

Uh oh!

et-nik May 16, 2026

Choose a reason for hiding this comment

Uh oh!

et-nik May 16, 2026

Choose a reason for hiding this comment

Uh oh!

et-nik May 16, 2026

Choose a reason for hiding this comment

Uh oh!

coveralls commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 25974081021

Coverage decreased (-0.2%) to 11.623%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coveralls commented May 16, 2026 •

edited

Loading