BUG :: Min/Max length not included on string if pattern is used

[gdbrown]

This is on the generated json-schema

    "utm_source": {
      "type": "string",
      "pattern": "^[\\w\\/\\.:-]+$",
      "pbj": {
        "type": "string",
        "rule": "single"
      }
    },
    "utm_medium": {
      "type": "string",
      "pattern": "^[\\w\\/\\.:-]+$",
      "pbj": {
        "type": "string",
        "rule": "single"
      }
    },
    "utm_term": {
      "type": "string",
      "pattern": "^[\\w\\s\\/\\.,:-]+$",
      "pbj": {
        "type": "string",
        "rule": "single"
      }
    },
    "utm_content": {
      "type": "string",
      "pattern": "^[\\w\\/\\.:-]+$",
      "pbj": {
        "type": "string",
        "rule": "single"
      }
    },
    "utm_campaign": {
      "type": "string",
      "pattern": "^[\\w\\/\\.:-]+$",
      "pbj": {
        "type": "string",
        "rule": "single"
      }
    },

[gdbrown]

i think we might have had this conversation before. let's discuss before you work on it.

[excelwebzone]

  {% if not field.enum and not hasPattern %}
    {% if field.type.typeName ~ '' in ['string', 'text', 'medium-text'] %}
      {% set minLength = field.minLength|default(0) %}
      {% if '' ~ minLength not in ['INF', 'NAN'] %}
        "minLength": {{ minLength }},
      {% endif %}

      {% set maxLength = field.maxLength|default(field.type.maxBytes) %}
      {% if '' ~ maxLength not in ['INF', 'NAN'] %}
        "maxLength": {{ maxLength }},
      {% endif %}
    {% elseif field.type.typeName ~ '' not in ['float', 'decimal', 'boolean', 'date', 'geo-point', 'message-ref', 'message'] %}
      {% set min = field.min|default(field.type.min) %}
      {% if '' ~ min not in ['INF', 'NAN'] %}
        "minimum": {{ min }},
      {% endif %}

      {% set max = field.max|default(field.type.max) %}
      {% if '' ~ max not in ['INF', 'NAN'] %}
        "maximum": {{ max }},
      {% endif %}
    {% endif %}
  {% endif %}

Based on what we spoke before, if type is enum or has a pattern we ignore setting min/max.

[gdbrown]

i'm going to leave this in the backlog. we should address it at some point.

[excelwebzone]

ok

[excelwebzone]

Moving back until we revisit it again