Apply review feedback from PR #40: fix missing RareLevel assignment and documentation#43
Merged
Merged
Conversation
…dd VoiceChannelLink Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Add rare ID and level support for recommended servers
Apply review feedback from PR #40: fix missing RareLevel assignment and documentation
Feb 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Applies follow-up fixes from PR #40 to ensure recommended-server “靓号” data is correctly populated and documented, and extends the exposed resources model to include an additional API field.
Changes:
- Sync
RecommendInfo.RareLevelfrom the API model duringRecommendInfo.Update(). - Add
VoiceChannelLinktoRareGuildResourcesand map it fromRareGuildSettingsinEntityExtensions. - Fix/standardize Chinese documentation text (typo, punctuation, and “靓号 ID” terminology).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Kook.Net.Rest/Extensions/EntityExtensions.cs | Maps new VoiceChannelLink from API RareGuildSettings into RareGuildResources. |
| src/Kook.Net.Rest/Entities/Guilds/RecommendInfo.cs | Fixes missing RareLevel assignment in Update() to keep entity in sync with API model. |
| src/Kook.Net.Core/Entities/Guilds/RareLevel.cs | Documentation punctuation fix for Intermediate. |
| src/Kook.Net.Core/Entities/Guilds/RareGuildResources.cs | Documentation typo fix and adds new optional VoiceChannelLink property. |
| src/Kook.Net.Core/Entities/Guilds/IRecommendInfo.cs | Documentation terminology correction (“自定义 ID” → “靓号 ID”). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gehongyan
added a commit
that referenced
this pull request
Feb 14, 2026
* Add rare ID and level support for recommended servers * Apply review feedback from PR #40: fix missing RareLevel assignment and documentation (#43) * Initial plan * Apply review feedback: fix missing RareLevel assignment, typos, and add VoiceChannelLink Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com> * Rename Resources property to RareResources in IRecommendInfo and RecommendInfo --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses review comments from the rare ID and level support implementation (PR #40).
Changes:
RareLevel = model.RareLevel;inRecommendInfo.Update()to sync with API modelRareGuildResources.IdIconRareLevel.Intermediateenum documentationIRecommendInfo.RareIdremarksVoiceChannelLinkproperty toRareGuildResourcesand mapping fromRareGuildSettingsAPI model💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.