Skip to content

Apply review feedback from PR #40: fix missing RareLevel assignment and documentation#43

Merged
gehongyan merged 2 commits into
recommend-rarefrom
copilot/sub-pr-40
Feb 14, 2026
Merged

Apply review feedback from PR #40: fix missing RareLevel assignment and documentation#43
gehongyan merged 2 commits into
recommend-rarefrom
copilot/sub-pr-40

Conversation

Copilot AI commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Addresses review comments from the rare ID and level support implementation (PR #40).

Changes:

  • Missing property assignment: Added RareLevel = model.RareLevel; in RecommendInfo.Update() to sync with API model
  • Documentation fixes:
    • Fixed typo "北京" → "背景" in RareGuildResources.IdIcon
    • Added missing period in RareLevel.Intermediate enum documentation
    • Corrected terminology "自定义 ID" → "靓号 ID" in IRecommendInfo.RareId remarks
  • Missing API field: Added VoiceChannelLink property to RareGuildResources and mapping from RareGuildSettings API model
public readonly struct RareGuildResources
{
    // ... existing properties ...
    
    /// <summary>
    ///     获取服务器靓号关联的语音频道链接。
    /// </summary>
    public string? VoiceChannelLink { get; init; }
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…dd VoiceChannelLink

Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI changed the title [WIP] Add rare ID and level support for recommended servers Apply review feedback from PR #40: fix missing RareLevel assignment and documentation Feb 13, 2026
Copilot AI requested a review from gehongyan February 13, 2026 14:46
@gehongyan gehongyan marked this pull request as ready for review February 14, 2026 01:17
Copilot AI review requested due to automatic review settings February 14, 2026 01:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies follow-up fixes from PR #40 to ensure recommended-server “靓号” data is correctly populated and documented, and extends the exposed resources model to include an additional API field.

Changes:

  • Sync RecommendInfo.RareLevel from the API model during RecommendInfo.Update().
  • Add VoiceChannelLink to RareGuildResources and map it from RareGuildSettings in EntityExtensions.
  • Fix/standardize Chinese documentation text (typo, punctuation, and “靓号 ID” terminology).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Kook.Net.Rest/Extensions/EntityExtensions.cs Maps new VoiceChannelLink from API RareGuildSettings into RareGuildResources.
src/Kook.Net.Rest/Entities/Guilds/RecommendInfo.cs Fixes missing RareLevel assignment in Update() to keep entity in sync with API model.
src/Kook.Net.Core/Entities/Guilds/RareLevel.cs Documentation punctuation fix for Intermediate.
src/Kook.Net.Core/Entities/Guilds/RareGuildResources.cs Documentation typo fix and adds new optional VoiceChannelLink property.
src/Kook.Net.Core/Entities/Guilds/IRecommendInfo.cs Documentation terminology correction (“自定义 ID” → “靓号 ID”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gehongyan gehongyan merged commit db2bbb9 into recommend-rare Feb 14, 2026
10 checks passed
@gehongyan gehongyan deleted the copilot/sub-pr-40 branch February 14, 2026 01:43
gehongyan added a commit that referenced this pull request Feb 14, 2026
* Add rare ID and level support for recommended servers

* Apply review feedback from PR #40: fix missing RareLevel assignment and documentation (#43)

* Initial plan

* Apply review feedback: fix missing RareLevel assignment, typos, and add VoiceChannelLink

Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: gehongyan <21241496+gehongyan@users.noreply.github.com>

* Rename Resources property to RareResources in IRecommendInfo and RecommendInfo

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants