I noticed when looking through this project that there was a lack of a LICENSE file.
Under normal conditions this would imply all rights reserved unless otherwise specified, as from your profile it states you reside in Texas, placing you presumably under US citizenship, and all the rights therein.
Please provide a license. I recommend the MIT, ISC (same as but shorter), CC-BY-NC, or GPLv3.0-only.
I don't want to spam issues so I'll place my disorganized concerns with the project here:
-
python2 dependence (Debian 12 does NOT like this), replace string.translate with import re; name = re.sub("[$2]", "", name); where $2 is the string contents of the second argument, in both cases. I'm not sure if this is compat to py2.
-
CC -> CXX, CFLAGS -> CXXFLAGS, this is C++, no? Also, LINK (should be LD per Make, -fuse-ld=$(LD) at link-time only, should be left implementation/system defined generally) seems unused, this is a library.
-
CPPFLAGS for compile-time only flags
-
use OBJECT := $(patsubst %,$(OBJECT_PATH)/%,$(SOURCE_LIST:.cpp=.o)) for a free OBJECTs list!
Lastly, I may append this later. Thank you for your project. I may or may not make a pull request containing some of my changes. I will assume this will go unanswered and that this project is no longer under support and is abandoned, Thank you for what you left behind.
I noticed when looking through this project that there was a lack of a LICENSE file.
Under normal conditions this would imply all rights reserved unless otherwise specified, as from your profile it states you reside in Texas, placing you presumably under US citizenship, and all the rights therein.
Please provide a license. I recommend the MIT, ISC (same as but shorter), CC-BY-NC, or GPLv3.0-only.
I don't want to spam issues so I'll place my disorganized concerns with the project here:
python2 dependence (Debian 12 does NOT like this), replace string.translate with import re; name = re.sub("[$2]", "", name); where $2 is the string contents of the second argument, in both cases. I'm not sure if this is compat to py2.
CC -> CXX, CFLAGS -> CXXFLAGS, this is C++, no? Also, LINK (should be LD per Make, -fuse-ld=$(LD) at link-time only, should be left implementation/system defined generally) seems unused, this is a library.
CPPFLAGS for compile-time only flags
use OBJECT :=$(patsubst %,$ (OBJECT_PATH)/%,$(SOURCE_LIST:.cpp=.o)) for a free OBJECTs list!
Lastly, I may append this later. Thank you for your project. I may or may not make a pull request containing some of my changes. I will assume this will go unanswered and that this project is no longer under support and is abandoned, Thank you for what you left behind.