From 820e11647f1bbba3e6a655d925db6a7d1f422fc5 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 13:54:42 +0300 Subject: [PATCH 01/12] unused parameter Update Parser_vectorstring.hpp --- include/rfl/parsing/Parser_vectorstring.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/Parser_vectorstring.hpp b/include/rfl/parsing/Parser_vectorstring.hpp index c64a8199..00d681da 100644 --- a/include/rfl/parsing/Parser_vectorstring.hpp +++ b/include/rfl/parsing/Parser_vectorstring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* _definitions) { + std::map* /*_definitions*/) { return schema::Type{schema::Type::Vectorstring{}}; } }; From 45e563abe4705bb6266a1aa2b98e70acda9062e4 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 13:55:40 +0300 Subject: [PATCH 02/12] unused parameter Update Parser_bytestring.hpp --- include/rfl/parsing/Parser_bytestring.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/Parser_bytestring.hpp b/include/rfl/parsing/Parser_bytestring.hpp index 75e9b9fb..1154c02f 100644 --- a/include/rfl/parsing/Parser_bytestring.hpp +++ b/include/rfl/parsing/Parser_bytestring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* _definitions) { + std::map* /*_definitions*/) { return schema::Type{schema::Type::Bytestring{}}; } }; From a7c1465de4d13d3c42a8552ca9b263e508a50a30 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 13:56:37 +0300 Subject: [PATCH 03/12] unused parameter Update FieldVariantParser.hpp --- include/rfl/parsing/FieldVariantParser.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/FieldVariantParser.hpp b/include/rfl/parsing/FieldVariantParser.hpp index ffd6a4dd..5c0fd82c 100644 --- a/include/rfl/parsing/FieldVariantParser.hpp +++ b/include/rfl/parsing/FieldVariantParser.hpp @@ -72,7 +72,7 @@ struct FieldVariantParser { } static schema::Type to_schema( - std::map* _definitions, + std::map* /*_definitions*/, std::vector _types = {}) { using VariantType = rfl::Variant...>; return Parser::to_schema(_definitions); From d2147b3e9f9cc5428e97b0c9d1f3077d3ab5e277 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 13:58:53 +0300 Subject: [PATCH 04/12] unused parameter Update OneOf.hpp --- include/rfl/OneOf.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/OneOf.hpp b/include/rfl/OneOf.hpp index d1fbb435..bad32d28 100644 --- a/include/rfl/OneOf.hpp +++ b/include/rfl/OneOf.hpp @@ -43,7 +43,7 @@ struct OneOf { static rfl::Result validate_impl(const T& _value, std::vector _errors) { return Head::validate(_value) - .and_then([&](auto&& _result) -> rfl::Result { + .and_then([&](auto&& /*_result*/) -> rfl::Result { if constexpr (sizeof...(Tail) == 0) { if (_errors.size() == sizeof...(Cs)) { return _value; From 4c25d1af8a807623905b791773b16de21bff3709 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:00:47 +0300 Subject: [PATCH 05/12] unused parameter Update FieldVariantParser.hpp --- include/rfl/parsing/FieldVariantParser.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/FieldVariantParser.hpp b/include/rfl/parsing/FieldVariantParser.hpp index 5c0fd82c..8f6eab80 100644 --- a/include/rfl/parsing/FieldVariantParser.hpp +++ b/include/rfl/parsing/FieldVariantParser.hpp @@ -73,7 +73,7 @@ struct FieldVariantParser { static schema::Type to_schema( std::map* /*_definitions*/, - std::vector _types = {}) { + std::vector /*_types = {}*/) { using VariantType = rfl::Variant...>; return Parser::to_schema(_definitions); } From dc18c1cf4cf90904efcad418abd980048b684093 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:07:22 +0300 Subject: [PATCH 06/12] unused parameters in parsers Update FieldVariantParser.hpp --- include/rfl/parsing/FieldVariantParser.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/FieldVariantParser.hpp b/include/rfl/parsing/FieldVariantParser.hpp index 8f6eab80..f508217f 100644 --- a/include/rfl/parsing/FieldVariantParser.hpp +++ b/include/rfl/parsing/FieldVariantParser.hpp @@ -72,7 +72,7 @@ struct FieldVariantParser { } static schema::Type to_schema( - std::map* /*_definitions*/, + std::map* _definitions, std::vector /*_types = {}*/) { using VariantType = rfl::Variant...>; return Parser::to_schema(_definitions); From ae2f8a249641f67adaaa189c46d6bf57191c5517 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:55:33 +0300 Subject: [PATCH 07/12] [[maybe_unused]] Update FieldVariantParser.hpp --- include/rfl/parsing/FieldVariantParser.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/FieldVariantParser.hpp b/include/rfl/parsing/FieldVariantParser.hpp index f508217f..f0621785 100644 --- a/include/rfl/parsing/FieldVariantParser.hpp +++ b/include/rfl/parsing/FieldVariantParser.hpp @@ -73,7 +73,7 @@ struct FieldVariantParser { static schema::Type to_schema( std::map* _definitions, - std::vector /*_types = {}*/) { + std::vector [[maybe_unused]] _types = {}) { using VariantType = rfl::Variant...>; return Parser::to_schema(_definitions); } From 8c8980e2eef64c2ca9918abe47939033854ec774 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:56:53 +0300 Subject: [PATCH 08/12] [[maybe_unused]] Update OneOf.hpp --- include/rfl/OneOf.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/OneOf.hpp b/include/rfl/OneOf.hpp index bad32d28..43b7d061 100644 --- a/include/rfl/OneOf.hpp +++ b/include/rfl/OneOf.hpp @@ -43,7 +43,7 @@ struct OneOf { static rfl::Result validate_impl(const T& _value, std::vector _errors) { return Head::validate(_value) - .and_then([&](auto&& /*_result*/) -> rfl::Result { + .and_then([&](auto&& [[maybe_unused]] _result) -> rfl::Result { if constexpr (sizeof...(Tail) == 0) { if (_errors.size() == sizeof...(Cs)) { return _value; From 2973dab4d3dbbe6862080cc0d440da6e04346fa0 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:58:06 +0300 Subject: [PATCH 09/12] [[maybe_unused]] Update Parser_bytestring.hpp --- include/rfl/parsing/Parser_bytestring.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/Parser_bytestring.hpp b/include/rfl/parsing/Parser_bytestring.hpp index 1154c02f..571302d3 100644 --- a/include/rfl/parsing/Parser_bytestring.hpp +++ b/include/rfl/parsing/Parser_bytestring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* /*_definitions*/) { + std::map* [[maybe_unused]] _definitions) { return schema::Type{schema::Type::Bytestring{}}; } }; From f4678cf93780a0abee096e19a920f0ff227fa9e6 Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 14:59:31 +0300 Subject: [PATCH 10/12] [[maybe_unused]] Update Parser_vectorstring.hpp --- include/rfl/parsing/Parser_vectorstring.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/rfl/parsing/Parser_vectorstring.hpp b/include/rfl/parsing/Parser_vectorstring.hpp index 00d681da..a5d8a8d2 100644 --- a/include/rfl/parsing/Parser_vectorstring.hpp +++ b/include/rfl/parsing/Parser_vectorstring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* /*_definitions*/) { + std::map* [[maybe_unused]] _definitions) { return schema::Type{schema::Type::Vectorstring{}}; } }; From 8fe2f566be61464f497efa2b1716bec5eb20879b Mon Sep 17 00:00:00 2001 From: KostinPavel <31876071+KostinPavel@users.noreply.github.com> Date: Thu, 20 Nov 2025 15:35:55 +0300 Subject: [PATCH 11/12] TODO Update OneOf.hpp --- include/rfl/OneOf.hpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/rfl/OneOf.hpp b/include/rfl/OneOf.hpp index 43b7d061..e47d77b3 100644 --- a/include/rfl/OneOf.hpp +++ b/include/rfl/OneOf.hpp @@ -43,10 +43,12 @@ struct OneOf { static rfl::Result validate_impl(const T& _value, std::vector _errors) { return Head::validate(_value) - .and_then([&](auto&& [[maybe_unused]] _result) -> rfl::Result { + .and_then([&](auto&& _result) -> rfl::Result { if constexpr (sizeof...(Tail) == 0) { if (_errors.size() == sizeof...(Cs)) { return _value; + // The AI suggests return std::forward(_result); + // is it correct in this context? } return error(make_error_message(_errors)); } else { From f4f6837778420741f46e301cab3857948b205164 Mon Sep 17 00:00:00 2001 From: Pavel Date: Thu, 20 Nov 2025 16:29:22 +0300 Subject: [PATCH 12/12] move [[maybe_unused]] for linux --- include/rfl/parsing/FieldVariantParser.hpp | 2 +- include/rfl/parsing/Parser_bytestring.hpp | 2 +- include/rfl/parsing/Parser_vectorstring.hpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/rfl/parsing/FieldVariantParser.hpp b/include/rfl/parsing/FieldVariantParser.hpp index f0621785..09900187 100644 --- a/include/rfl/parsing/FieldVariantParser.hpp +++ b/include/rfl/parsing/FieldVariantParser.hpp @@ -73,7 +73,7 @@ struct FieldVariantParser { static schema::Type to_schema( std::map* _definitions, - std::vector [[maybe_unused]] _types = {}) { + [[maybe_unused]] std::vector _types = {}) { using VariantType = rfl::Variant...>; return Parser::to_schema(_definitions); } diff --git a/include/rfl/parsing/Parser_bytestring.hpp b/include/rfl/parsing/Parser_bytestring.hpp index 571302d3..f932cb8c 100644 --- a/include/rfl/parsing/Parser_bytestring.hpp +++ b/include/rfl/parsing/Parser_bytestring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* [[maybe_unused]] _definitions) { + [[maybe_unused]] std::map* _definitions) { return schema::Type{schema::Type::Bytestring{}}; } }; diff --git a/include/rfl/parsing/Parser_vectorstring.hpp b/include/rfl/parsing/Parser_vectorstring.hpp index a5d8a8d2..c4cbfd91 100644 --- a/include/rfl/parsing/Parser_vectorstring.hpp +++ b/include/rfl/parsing/Parser_vectorstring.hpp @@ -28,7 +28,7 @@ struct Parser { } static schema::Type to_schema( - std::map* [[maybe_unused]] _definitions) { + [[maybe_unused]] std::map* _definitions) { return schema::Type{schema::Type::Vectorstring{}}; } };