Fix link in the documentation#579
Conversation
Summary of ChangesHello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important documentation issue by correcting a link within the installation instructions. The change ensures that the reference to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix a link in the documentation by removing it. While removing a potentially broken link is a good step, it leaves the installation instructions for ROS 2 integration incomplete and confusing for users. My feedback suggests either restoring the link with a correct URL or updating the instructions to provide a clear alternative method.
|
|
||
| 1. Fetch the sources with `vcs` using the `.repos` file from the | ||
| [tea-ros2](https://github.com/getml/tea-ros2) workspace, which already | ||
| tea-ros2 workspace, which already |
There was a problem hiding this comment.
This change removes the link to the tea-ros2 workspace. While the link may have been incorrect, its removal makes this part of the documentation difficult to follow. Users are instructed to use a .repos file from the tea-ros2 workspace but are no longer given a way to locate it.
To make these instructions actionable, could you please either:
- Update the line with the correct link to the
tea-ros2workspace. - If that workspace is no longer the recommended source, revise the instructions to describe the current correct procedure for ROS 2 integration.
This will ensure the documentation remains helpful and accurate for users.
No description provided.