Remove reference to internals in error message for unused values

[BugelNiels]

Prevents exposing library internals in the error message when a value is not used (triggered when rfl::NoExtraFields is used).

fixes #598

[gemini-code-assist]

Summary of Changes

Hello @BugelNiels, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity and abstraction of error messages within the rfl library. By removing internal implementation specifics from a particular error message, it aims to provide users with more concise and user-friendly feedback, enhancing the overall developer experience without revealing unnecessary library internals.

Highlights

• Error Message Refinement: The error message displayed when a value is not used (e.g., with rfl::NoExtraFields) has been simplified to remove references to internal library components, preventing exposure of implementation details.

Changelog

• include/rfl/parsing/ViewReader.hpp
  • Modified the error message for unused values to remove explicit mentions of rfl::NoExtraFields or rfl::ExtraFields, making the message more generic and less revealing of internal library mechanisms.

Activity

• The pull request was created by BugelNiels.
• No human activity (comments, reviews) has occurred yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies an error message for unused values to avoid exposing library-specific type names. While this is a reasonable goal, the change makes the error message less informative for developers. My feedback includes a suggestion for a more descriptive error message that still avoids mentioning specific types. Additionally, I recommend adding a new test case to cover this scenario, which would validate the error message and prevent future regressions.

[gemini-code-assist]

This change simplifies the error message, but it also removes helpful context for the developer. While I understand the goal of not exposing library-specific names, the new message might leave developers wondering why an unused field is an error. A good compromise could be to add a hint explaining the reason, which would improve the developer experience without being too specific.

Suggested change

	stream << "Value named '" << _current_name_or_index
	<< "' not used. Remove the rfl::NoExtraFields processor or add "
	"rfl::ExtraFields to avoid this error message.";
	<< "' not used.";
	stream << "Value named '" << _current_name_or_index
	<< "' not used (extra fields are not allowed).";

[liuzicheng1987]

@BugelNiels thanks for the contribution!