Commit 1212ab3
committed
test(notes): pin the read-only lock to the real editor
The teleprompter suite stubs @tiptap/react wholesale, so its read-only
assertions pin the props handed to Tiptap rather than what Tiptap does
with them. useEditor honours `editable` at creation and then pins every
later option pass to the editor own isEditable, which leaves setEditable
as the single path carrying a mirror toggle. Losing it - to a refactor or
a Tiptap upgrade - would leave every mocked assertion green with a
mirrored note still editable, the exact bug this branch fixes.
NotesWindow.editable.test.tsx drives the real editor through a mirror
toggle and reads contenteditable back off the DOM; removing the
setEditable effect fails it. The constructor option stays pinned at the
mocked boundary, since React flushes the effect before a test can observe
the first paint - the comment there now says so rather than claiming the
mock proves creation-time behaviour.
Also stop the playback-label test from rendering isPlaying with
formatting still enabled, a state NotesWindow cannot produce.1 parent 54ba303 commit 1212ab3
3 files changed
Lines changed: 55 additions & 3 deletions
File tree
- src/components/launch
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
316 | | - | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
317 | 319 | | |
318 | 320 | | |
319 | 321 | | |
| |||
0 commit comments