Commit 6112f4f
committed
fix(ci): start release notes from a tag that exists
The notes range was built from the previous release's *name*, never from a check
that it exists. 1.9.3 shipped only as rc.1, so v1.9.4-rc.1 asked git for
v1.9.3..v1.9.4-rc.1 and the publish step died on `unknown revision` -- after all
four platforms had already built and uploaded their artifacts.
The existing rc walk-down covers a skipped RC. Nothing covered a skipped stable,
and that loop does not run at all for an rc.1 (`for n = 0; n >= 1`).
This is not only about release notes: publish-msstore has `needs:
publish-release`, so the same missing tag would have taken the Store deployment
down with it on a stable promotion, which is the one place that failure is
expensive to discover.
Falls back to the nearest tag reachable from the release commit's parent, which
is what "since the last release" meant to begin with -- v1.9.2 for the tag that
failed, a 25-commit range. If no tag is reachable at all, the root commit keeps
the range valid rather than handing git an empty left-hand side.1 parent e032894 commit 6112f4f
1 file changed
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
745 | 745 | | |
746 | 746 | | |
747 | 747 | | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
748 | 766 | | |
749 | 767 | | |
750 | 768 | | |
| |||
0 commit comments