Commit e2e41c9
committed
fix(agent): give the harness its margin, and name the mandatory points correctly
Four review findings, all correct.
`testTimeout` was set to exactly `DEFAULT_TURN_TIMEOUT_MS`, which does not fix the
race it was meant to fix — equal deadlines only make it unbiased. The harness has
to win for a slow turn to be classified as TIMEOUT instead of dying as a killed
worker, so the vitest deadline now sits 30 s above it.
`overBudget` listed shape changes, non-move events and parked-run ends, but the
mandatory set also always holds the first and last sample: a two-point track under
`maxPoints: 1` overflows for a reason the message did not name, and the model was
told something false. Both the JSDoc and the message now say mandatory points, and
enumerate all four kinds.
And two comments: the test said the shape flips every 100 ms where `sweep` samples
at 50 ms and alternates on every index, and a comment in `workbench/l0/` pointed at
`README.md`, which from there resolves to a file that does not exist.1 parent e9c482c commit e2e41c9
4 files changed
Lines changed: 23 additions & 19 deletions
File tree
- src/lib/ai-edition/timeline
- workbench/l0
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
226 | | - | |
227 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
228 | 229 | | |
229 | 230 | | |
230 | 231 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
328 | 329 | | |
329 | 330 | | |
330 | 331 | | |
331 | | - | |
332 | | - | |
333 | | - | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
334 | 336 | | |
335 | 337 | | |
336 | 338 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
| 78 | + | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
0 commit comments