Skip to content

Commit ffed2b1

Browse files
committed
docs(testing): address CodeRabbit review on the RC checklist
- Mark the #115 stop-completion item Windows-only and explicit about needing real Windows hardware (the native WGC stop path it guards isn't exercised on macOS/Linux). - Add a Platform column to the results log so each run records which OS it covered. - Loosen "reproduces twice" to only apply to ambiguous/flaky-looking issues; crashes, hangs, data loss, and security issues get logged on first occurrence. - Tighten the system-audio checklist item to require two recordings in opposite toggle states (not just "two separate recordings"), with playback verified to actually match each state.
1 parent a5e1858 commit ffed2b1

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

docs/testing/rc-e2e-checklist.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ build/commit tested and any findings (with a linked issue) at the bottom.
1717
`Openscreen.exe`/`Openscreen.app` for a packaged build).
1818
3. Work through the sections in order — later sections (Editor, Persistence) depend
1919
on having a real recording from the Capture section.
20-
4. A finding is a bug only if it reproduces twice. Note the repro steps.
20+
4. Crashes, hangs, data loss, and security issues are logged the first time they occur — note full repro details immediately, don't wait to reproduce twice. For anything else (a one-off visual glitch, a flaky-looking timing issue), reproduce it again before treating it as a real finding rather than noise.
2121

2222
---
2323

@@ -28,7 +28,7 @@ build/commit tested and any findings (with a linked issue) at the bottom.
2828
- [x] Selecting a source works for **full screen**
2929
- [x] Selecting a source works for a **single app window** (not just full screen — regression check for #60: confirm the recorded video is NOT a black screen, including a window with an odd-pixel client size if you can arrange one)
3030
- [x] Record start/stop works from the HUD
31-
- [x] **Stop reliably completes** with system audio/mic/webcam/cursor all *disabled* (regression check for #115: this combination used to hang indefinitely on Windows) — confirm the editor opens within a few seconds of clicking stop
31+
- [x] **Windows only****Stop reliably completes** with system audio/mic/webcam/cursor all *disabled* (regression check for #115: this combination used to hang indefinitely on Windows) — confirm the editor opens within a few seconds of clicking stop. Must be run on real Windows; the native WGC stop path this guards isn't exercised on macOS/Linux
3232
- [x] Stop reliably completes with system audio + mic + webcam + cursor all *enabled* (no regression to the normal path)
3333
- [ ] Tray icon "Stop Recording" works while recording (right-click → Stop, or left/double-click to refocus the HUD if it's minimized) — not exercised in the 2026-07-19 pass, worth covering next run
3434
- [ ] Opening an existing video file works from the launch window — not exercised in the 2026-07-19 pass
@@ -40,7 +40,7 @@ build/commit tested and any findings (with a linked issue) at the bottom.
4040

4141
- [x] Mic toggle on/off works before recording
4242
- [x] Mic device selection (if multiple mics available) works
43-
- [x] System audio toggle works — verify across **two separate recordings** (toggle state isn't sticky/stale between them)
43+
- [x] System audio toggle works — verify with **two separate recordings in opposite toggle states** (one with it enabled, one disabled), and confirm each recording's playback actually matches its state (audible system audio only in the enabled one) rather than just checking the toggle isn't sticky/stale
4444
- [ ] Mic-only recording produces audible mic audio on playback — only the combined mic+system-audio path was exercised this pass
4545
- [ ] System-audio-only recording produces audible system audio on playback — only the combined path was exercised this pass
4646
- [x] Mic + system audio together: both are audible and levels are reasonably balanced (not one drowning out the other)
@@ -95,6 +95,6 @@ build/commit tested and any findings (with a linked issue) at the bottom.
9595

9696
## Results log
9797

98-
| Date | Build / commit tested | Tester | Findings |
99-
|------|------------------------|--------|----------|
100-
| 2026-07-19 | `release/v1.7.0` (post-#124 cherry-pick, pre-#125/#127) | Claude (computer-use) | 2 bugs found and fixed: (1) annotation placeholder text baked into content instead of being empty — PR #127; (2) post-reload duration capped at last element's end time — PR #127. Everything else checked above passed. Windows only; macOS section untestable without hardware. A few items (mic-only/system-audio-only isolation, webcam mirroring/reactive zoom, auto-zoom live re-verification, tray stop, countdown overlay, existing-video-file import) weren't exercised this pass and are called out inline above for next time. |
98+
| Date | Build / commit tested | Platform | Tester | Findings |
99+
|------|------------------------|----------|--------|----------|
100+
| 2026-07-19 | `release/v1.7.0` (post-#124 cherry-pick, pre-#125/#127) | Windows | Claude (computer-use) | 2 bugs found and fixed: (1) annotation placeholder text baked into content instead of being empty — PR #127; (2) post-reload duration capped at last element's end time — PR #127. Everything else checked above passed. macOS section untestable without hardware. A few items (mic-only/system-audio-only isolation, webcam mirroring/reactive zoom, auto-zoom live re-verification, tray stop, countdown overlay, existing-video-file import) weren't exercised this pass and are called out inline above for next time. |

0 commit comments

Comments
 (0)