From c8037f062651f2fb24aeb474196796bd9a296ed7 Mon Sep 17 00:00:00 2001 From: Marek Nagy Date: Fri, 17 Apr 2026 09:56:58 +0200 Subject: [PATCH 1/2] fix: wait for AWS ECR to get password --- shell/lib/docker/authn/aws-ecr.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shell/lib/docker/authn/aws-ecr.sh b/shell/lib/docker/authn/aws-ecr.sh index 27fd7aacc..1332ef840 100644 --- a/shell/lib/docker/authn/aws-ecr.sh +++ b/shell/lib/docker/authn/aws-ecr.sh @@ -14,7 +14,9 @@ ecr_auth() { region="$(echo "$registry" | cut -d. -f4)" info_sub "Authenticating with AWS ECR in $registry" # See: https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html#registry-auth-token - aws ecr get-login-password --region "$region" | docker login --username AWS --password-stdin "$registry" + # Capture the password first to avoid pipe stdin issues in non-TTY CI environments. + ecr_password="$(aws ecr get-login-password --region "$region")" + docker login --username AWS --password-stdin "$registry" <<< "$ecr_password" } # ensure_ecr_repository ensures that an ECR repository exists. From d544742a3166eadc87daf6e4bbeaf3b8a1b6a3d1 Mon Sep 17 00:00:00 2001 From: Marek Nagy Date: Fri, 17 Apr 2026 10:00:09 +0200 Subject: [PATCH 2/2] make fmt && make lint --- mise.lock | 1 + shell/lib/docker/authn/aws-ecr.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/mise.lock b/mise.lock index 664d8f0d9..a02f45dc9 100644 --- a/mise.lock +++ b/mise.lock @@ -18,6 +18,7 @@ url = "https://github.com/bats-core/bats-core/archive/refs/tags/v1.13.0.tar.gz" url = "https://github.com/bats-core/bats-core/archive/refs/tags/v1.13.0.tar.gz" [tools.bats."platforms.macos-arm64"] +checksum = "blake3:d34af9fd0f9101d5309b2de31f3d1699e56a574d7d4b5e6380580a9e758a9744" url = "https://github.com/bats-core/bats-core/archive/refs/tags/v1.13.0.tar.gz" [tools.bats."platforms.macos-x64"] diff --git a/shell/lib/docker/authn/aws-ecr.sh b/shell/lib/docker/authn/aws-ecr.sh index 1332ef840..7128af166 100644 --- a/shell/lib/docker/authn/aws-ecr.sh +++ b/shell/lib/docker/authn/aws-ecr.sh @@ -16,7 +16,7 @@ ecr_auth() { # See: https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html#registry-auth-token # Capture the password first to avoid pipe stdin issues in non-TTY CI environments. ecr_password="$(aws ecr get-login-password --region "$region")" - docker login --username AWS --password-stdin "$registry" <<< "$ecr_password" + docker login --username AWS --password-stdin "$registry" <<<"$ecr_password" } # ensure_ecr_repository ensures that an ECR repository exists.