Skip to content

Replace install platform dropdown with button group #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bschellenberger2600 wants to merge 1 commit into from
Closed

Replace install platform dropdown with button group #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions src/components/InstallPicker.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const releasesUrl =
: 'https://github.com/git-fire/git-rain/releases';

const labelId = `platform-label-${product}`;
const platformGroupId = `platform-group-${product}`;
---

<div
Expand All @@ -22,13 +23,38 @@ const labelId = `platform-label-${product}`;
data-product={product}
>
{!embedded && <p class="install-picker__title">{title}</p>}
<label id={labelId} for={`platform-${product}`}>{embedded ? 'Install' : 'Platform'}</label>
<select id={`platform-${product}`} data-install-select aria-labelledby={labelId}>
<option value="macos">macOS — Homebrew</option>
<option value="windows">Windows — winget</option>
<option value="linux">Linux</option>
<option value="go">Any — Go install</option>
</select>
<p id={labelId} class="install-picker__label">{embedded ? 'Install' : 'Platform'}</p>
<div
id={platformGroupId}
class="install-picker__platforms"
role="radiogroup"
aria-labelledby={labelId}
>
<button
type="button"
role="radio"
aria-checked="false"
class="install-picker__platform-btn"
data-install-platform="macos">macOS</button>
<button
type="button"
role="radio"
aria-checked="false"
class="install-picker__platform-btn"
data-install-platform="windows">Windows</button>
<button
type="button"
role="radio"
aria-checked="false"
class="install-picker__platform-btn"
data-install-platform="linux">Linux</button>
<button
type="button"
role="radio"
aria-checked="false"
class="install-picker__platform-btn"
data-install-platform="go">Go</button>
</div>
<pre><code data-install-command></code></pre>
<div class="install-picker__actions">
<button type="button" data-install-copy>Copy</button>
Expand Down
100 changes: 89 additions & 11 deletions src/scripts/install-pickers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ type OsFamily = 'macos' | 'windows' | 'linux' | 'go';

const STORAGE_KEY = 'git-fire-site-install-os';

const PLATFORM_ORDER: OsFamily[] = ['macos', 'windows', 'linux', 'go'];

function coerceOs(value: string | undefined): OsFamily | null {
if (value === 'macos' || value === 'windows' || value === 'linux' || value === 'go') return value;
return null;
}

function detectOs(): OsFamily {
if (typeof navigator === 'undefined') return 'go';
const uaData = navigator.userAgentData;
Expand Down Expand Up @@ -92,16 +99,32 @@ function commandBlock(product: ProductId, os: OsFamily): { command: string; note
}
}

function selectedOs(root: HTMLElement): OsFamily {
const active = root.querySelector<HTMLButtonElement>(
'[data-install-platform][aria-checked="true"]',
);
return coerceOs(active?.dataset.installPlatform) ?? PLATFORM_ORDER[0];
}

function syncPlatformButtons(root: HTMLElement, os: OsFamily) {
root.querySelectorAll<HTMLButtonElement>('[data-install-platform]').forEach((btn) => {
const v = coerceOs(btn.dataset.installPlatform);
const isSelected = v === os;
btn.setAttribute('aria-checked', isSelected ? 'true' : 'false');
btn.tabIndex = isSelected ? 0 : -1;
btn.classList.toggle('install-picker__platform-btn--active', isSelected);
});
}

function renderPicker(root: HTMLElement) {
const product = root.dataset.product as ProductId;
if (product !== 'git-fire' && product !== 'git-rain') return;

const select = root.querySelector<HTMLSelectElement>('[data-install-select]');
const pre = root.querySelector<HTMLElement>('[data-install-command]');
const noteEl = root.querySelector<HTMLElement>('[data-install-note]');
if (!select || !pre || !noteEl) return;
if (!pre || !noteEl) return;

const os = select.value as OsFamily;
const os = selectedOs(root);
const { command, note } = commandBlock(product, os);
pre.textContent = command;
noteEl.textContent = note;
Expand All @@ -110,28 +133,83 @@ function renderPicker(root: HTMLElement) {
function setPlatformEverywhere(os: OsFamily) {
persistOs(os);
document.querySelectorAll<HTMLElement>('[data-install-picker]').forEach((root) => {
const select = root.querySelector<HTMLSelectElement>('[data-install-select]');
if (select) select.value = os;
syncPlatformButtons(root, os);
renderPicker(root);
});
}

function bindPlatformRadiogroup(root: HTMLElement) {
const group = root.querySelector<HTMLElement>('.install-picker__platforms');
const buttons = root.querySelectorAll<HTMLButtonElement>('[data-install-platform]');
if (!group || buttons.length === 0) return;

group.addEventListener('keydown', (event) => {
if (!(event.target instanceof HTMLButtonElement)) return;
if (!event.target.matches('[data-install-platform]')) return;

const current = coerceOs(event.target.dataset.installPlatform);
if (!current) return;

let next: OsFamily | null = null;

switch (event.key) {
case 'ArrowRight':
case 'ArrowDown': {
event.preventDefault();
const i = PLATFORM_ORDER.indexOf(current);
next = PLATFORM_ORDER[Math.min(i + 1, PLATFORM_ORDER.length - 1)];
break;
}
case 'ArrowLeft':
case 'ArrowUp': {
event.preventDefault();
const i = PLATFORM_ORDER.indexOf(current);
next = PLATFORM_ORDER[Math.max(i - 1, 0)];
break;
}
case 'Home': {
event.preventDefault();
next = PLATFORM_ORDER[0];
break;
}
case 'End': {
event.preventDefault();
next = PLATFORM_ORDER[PLATFORM_ORDER.length - 1];
break;
}
default:
return;
}

if (next) {
setPlatformEverywhere(next);
queueMicrotask(() => {
root.querySelector<HTMLButtonElement>(`[data-install-platform="${next}"]`)?.focus();
});
}
});

buttons.forEach((btn) => {
btn.addEventListener('click', () => {
const os = coerceOs(btn.dataset.installPlatform);
if (os) setPlatformEverywhere(os);
});
});
}

function bindPicker(root: HTMLElement) {
const product = root.dataset.product as ProductId;
if (product !== 'git-fire' && product !== 'git-rain') return;

const select = root.querySelector<HTMLSelectElement>('[data-install-select]');
const copyBtn = root.querySelector<HTMLButtonElement>('[data-install-copy]');

if (!select || !copyBtn) return;
if (!copyBtn) return;

const initial = storedOs() ?? detectOs();
select.value = initial;
syncPlatformButtons(root, initial);
renderPicker(root);

select.addEventListener('change', () => {
setPlatformEverywhere(select.value as OsFamily);
});
bindPlatformRadiogroup(root);

copyBtn.addEventListener('click', async () => {
const pre = root.querySelector<HTMLElement>('[data-install-command]');
Expand Down
54 changes: 41 additions & 13 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ a:hover {
border-color: color-mix(in srgb, var(--color-border) 80%, var(--color-rain));
}

.install-picker--embedded label {
.install-picker--embedded .install-picker__label {
margin-bottom: var(--space-xs);
}

Expand All @@ -470,25 +470,53 @@ a:hover {
font-size: 0.8125rem;
}

.install-picker label {
.install-picker__label {
display: block;
font-size: 0.8125rem;
font-weight: 600;
color: var(--color-muted);
margin-bottom: var(--space-sm);
margin: 0 0 var(--space-sm);
}

.install-picker select {
width: 100%;
.install-picker__platforms {
display: flex;
flex-wrap: wrap;
gap: var(--space-xs);
margin-bottom: var(--space-md);
max-width: 22rem;
padding: var(--space-sm) var(--space-md);
}

.install-picker__platform-btn {
font: inherit;
font-size: 0.9375rem;
color: var(--color-text);
background: var(--color-bg);
border: 1px solid color-mix(in srgb, var(--color-border) 80%, var(--color-text));
font-size: 0.8125rem;
font-weight: 600;
padding: var(--space-xs) var(--space-sm);
border-radius: var(--radius-sm);
margin-bottom: var(--space-md);
border: 1px solid color-mix(in srgb, var(--color-border) 85%, var(--color-text));
background: var(--color-bg);
color: var(--color-muted);
cursor: pointer;
transition:
border-color 0.15s ease,
background 0.15s ease,
color 0.15s ease;
}

.install-picker__platform-btn:hover {
color: var(--color-text);
border-color: color-mix(in srgb, var(--color-border) 55%, var(--color-text));
}

.install-picker[data-product='git-fire'] .install-picker__platform-btn--active {
color: var(--color-fire);
border-color: color-mix(in srgb, var(--color-fire) 45%, var(--color-border));
background: color-mix(in srgb, var(--color-fire) 12%, var(--color-bg));
}

.install-picker[data-product='git-rain'] .install-picker__platform-btn--active {
color: var(--color-rain);
border-color: color-mix(in srgb, var(--color-rain) 45%, var(--color-border));
background: color-mix(in srgb, var(--color-rain) 12%, var(--color-bg));
}

.install-picker pre {
Expand All @@ -513,7 +541,7 @@ a:hover {
margin-bottom: var(--space-md);
}

.install-picker button {
.install-picker__actions button {
font: inherit;
font-size: 0.875rem;
font-weight: 600;
Expand All @@ -526,7 +554,7 @@ a:hover {
transition: border-color 0.15s ease, background 0.15s ease;
}

.install-picker button:hover {
.install-picker__actions button:hover {
border-color: var(--color-rain-dim);
background: color-mix(in srgb, var(--color-rain) 12%, var(--color-surface));
}
Expand Down
Loading