autodns: use the right response structure #2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmke
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of issue #2725, I checked the response structure of the API, and it seems that the response structures were wrong.
As the structure was defining non-existent fields, there was no error.
I think I will need the response structure because of the issue #2725.
The behavior of the API is not clear in some cases, so I prefer to be able to check the response structure if needed.
I also improved the error parsing: the API doesn't provide an error example, but there is an example in the issue #2725 (comment).
The API documentation is painful to use because of DDOS protection, so I prefer to use https://generator.swagger.io/?url=https://raw.githubusercontent.com/InterNetX/domainrobot-api/refs/heads/master/src/domainrobot.json#/Zone%20Tasks/zoneStream