Positioning of overlapping labels in pie-chart

[mous-myndr]

I like the Graph library very much, just wanted the labels to be placed a bit better on small slices. See attached images the before/after screenshots: The before has the labels through each other, the second has that fixed. What I do, is I added an option 'label_position_delta_for_small_slices' => .1. I added some code in dataLabelPosition that looks at the degrees of a slice and the neighbour slices and adds or subtracts the amount given by the option if applicable.
Before:

After:

I have a clone of the repo with a pull request. I'm just not sure how to submit that here as a pull request...
See mous-myndr/SVGGraph#1

[goat1000]

Thanks Paul - I did get your email, but this is the first chance I have had to look at it.

I think you have created a branch in your fork, and the pull request you made is into your own master - so you would have to merge it into your master branch and do the pull request from there. Or at least I think so.

Or if you prefer I can create a patch from your code and add it in from this end.

[mous-myndr]

Hi, I looked at pull requests again and it seems I have to create it on your repo, but to do that, I must be a contributor. Then I can choose my own repo as source. I’m willing to do that, but perhaps for this one-time issue that is not the most practical. So I included a patch should you want to merge it yourself. Let me know what suits you best. For me, both is fine, I don’t really need the credits. Best, Paul <https://www.myndr.nl/> Marspoortstraat 13 7201 JA Zutphen myndr.nl <http://myndr.nl/> +31(0)85 130 3814 KVK 69503370 Paul Mourus 06-18546748

On 21 Oct 2024, at 12:06, goat1000 ***@***.***> wrote: Thanks Paul - I did get your email, but this is the first chance I have had to look at it. I think you have created a branch in your fork, and the pull request you made is into your own master - so you would have to merge it into your master branch and do the pull request from there. Or at least I think so. Or if you prefer I can create a patch from your code and add it in from this end. — Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMHJK6XGIYEHQQEWW3KCBZ3Z4TG4FAVCNFSM6AAAAABQF2SZCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRWGIZDAOBUGU>. You are receiving this because you authored the thread.



[goat1000]

The pull request happens from the master branch of your repository - you automatically become a contributor when the changes from the pull request are merged in.

If you go to your master branch you should see a "Contribute" button where you can open a new pull request.