fix(sprout): add curl -f -L flags and normalize indentation#7
Merged
Conversation
- Add -f (fail on HTTP errors) and -L (follow redirects) to curl command when downloading the sprout binary, matching the farmer script behavior. Without -f, a 404 response would silently write an error page as the binary. - Normalize indentation from spaces to tabs throughout the install section for consistency with the farmer script and the rest of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
-f(fail on HTTP errors) and-L(follow redirects) flags to thecurlcommand when downloading the sprout binary, matching the farmer script's behavior-f, a 404 or other HTTP error would silently write the error page content as the binary — leading to a broken install with no error messageTesting
shellcheck latest/farmer latest/sproutpasses clean