isObject should not include check for having a constructor

[mb-dev]

Mongo lean objects don't have a constructor, so using isObject return false

isObject = (value) ->
  return false if not value?
  return false if typeof value isnt 'object'
  value.constructor is Object # <-- should not exist

[asalant]

You mean Mongoose lean objects?

Are you saying that getto is not adding get to lean objects from
Mongoose? I don't think that's true as that is one of the primary uses
cases for getto throughout our codebase.

On Wed, Aug 13, 2014 at 1:49 PM, Moshe Bergman notifications@github.com
wrote:

Mongo lean objects don't have a constructor, so using isObject return false

isObject = (value) ->
return false if not value?
return false if typeof value isnt 'object'
value.constructor is Object # <-- should not exist

—
Reply to this email directly or view it on GitHub
#4.

eat well with good eggs on: twitter http://twitter.com/goodeggs ||
facebook http://facebook.com/goodeggs || blog http://blog.goodeggs.com/

[mb-dev]

I got "Not an object" exceptions when trying to use gettoize on the lean objects. Do you want me to show you tomorrow?

[asalant]

Sure. I expect there is something else going on as we use getto on Mongoose lean objects a lot. If you use a model mixin on a lean object, getto is invoked so the mixin will work.

gettoize is not part of getto so maybe there is something in its usage?

I think Brian Underwood ran into this issue trying to use getto directly in the console and we didn't get to the bottom of that.

Do you have a failing example to point me at? This code added to product.spec passes for me:

    it 'has a constructor when lean', ->
      getto = require 'getto'
      product = Product.findOne().lean().sync.exec()
      console.log product.constructor
      expect(product.constructor).toBe Object
      getto(product)
      expect(product.get).toBeDefined()

and the output of the console.log line is:

[Function: Object]