[tflite] Complex64 type is rendered with an additional space

[justinchuby]

For some reason the complex64 type is rendered as comple x 64 with spaces around x. I think it is due to some rule that puts spaces around x for mlir models, but this affects the complex types.

[aravindmurali22]

Hi @justinchuby , thanks for filing this issue. I've investigated the issue and found the cause. It appears that the tensor_shape processing logic in src/ui/src/components/visualizer/worker/graph_processor.ts blindly adds spaces around x to format dimensions (e.g., 1x2 -> 1 x 2), but this regex-like behavior inadvertently affects types containing x, such as complex64.

The problematic code is around line 834:

model-explorer/src/ui/src/components/visualizer/worker/graph_processor.ts

Lines 827 to 836 in 17ca4d7

	// Special handlings.
	if (key === 'tensor_shape') {
	key = 'shape';
	value = value
	.replace('tensor<', '')
	.replace('>', '')
	.replace('*', '∗')
	.split('x')
	.join(' x ');
	}

Work around: To fix this, we should replace the .split('x').join(' x ') with a regex replacement that only targets x when it's likely being used as a dimension separator (e.g., preceded by a digit or ?).

Replace:

model-explorer/src/ui/src/components/visualizer/worker/graph_processor.ts

Lines 834 to 835 in 17ca4d7

	.split('x')
	.join(' x ');

With:
.replace(/(\d|\?)x/g, '$1 x ');

This will ensure that 4x4 becomes 4 x 4, but complex64 remains complex64.

[github-actions]

Marking this issue as stale since it has been open for 7 days with no activity. This issue will be closed if no further activity occurs.

[justinchuby]

Thanks- do you intend to merge this patch?

[aravindmurali22]

Hi @justinchuby, thank you for the response. I'll go ahead and create an internal CL, and I will let you know as soon as the patch is merged.