From 9a5ff59f2762326decab83f3a2b0f65b9a43bca6 Mon Sep 17 00:00:00 2001
From: Varun Nuthalapati <nuthalapativarun@gmail.com>
Date: Mon, 1 Jun 2026 18:25:39 -0700
Subject: [PATCH] docs: add TSDoc to BasicLlmRequestProcessor,
 IdentityLlmRequestProcessor, and RequestConfirmationLlmRequestProcessor

Add @param and @yields TSDoc to the runAsync overrides in the three processors
that were missing inline documentation.
---
 .../agents/processors/basic_llm_request_processor.ts   |  7 +++++++
 .../processors/identity_llm_request_processor.ts       |  7 +++++++
 .../request_confirmation_llm_request_processor.ts      | 10 +++++++++-
 3 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/core/src/agents/processors/basic_llm_request_processor.ts b/core/src/agents/processors/basic_llm_request_processor.ts
index 56eb9b47..552c9855 100644
--- a/core/src/agents/processors/basic_llm_request_processor.ts
+++ b/core/src/agents/processors/basic_llm_request_processor.ts
@@ -16,6 +16,13 @@ import {BaseLlmRequestProcessor} from './base_llm_processor.js';
  * connect settings.
  */
 export class BasicLlmRequestProcessor extends BaseLlmRequestProcessor {
+  /**
+   * Populates model name, generation config, output schema, and live connect
+   * settings on the request from the agent and run config.
+   *
+   * @param invocationContext - The current invocation context.
+   * @param llmRequest - The request object to populate in place.
+   */
   // eslint-disable-next-line require-yield
   override async *runAsync(
     invocationContext: InvocationContext,
diff --git a/core/src/agents/processors/identity_llm_request_processor.ts b/core/src/agents/processors/identity_llm_request_processor.ts
index 3c5c58a0..eb06b432 100644
--- a/core/src/agents/processors/identity_llm_request_processor.ts
+++ b/core/src/agents/processors/identity_llm_request_processor.ts
@@ -14,6 +14,13 @@ import {BaseLlmRequestProcessor} from './base_llm_processor.js';
  * informing the model of the agent's name and description.
  */
 export class IdentityLlmRequestProcessor extends BaseLlmRequestProcessor {
+  /**
+   * Appends agent name and description as identity instructions to the system
+   * prompt of the request.
+   *
+   * @param invocationContext - The current invocation context.
+   * @param llmRequest - The request object to append instructions to.
+   */
   // eslint-disable-next-line require-yield
   override async *runAsync(
     invocationContext: InvocationContext,
diff --git a/core/src/agents/processors/request_confirmation_llm_request_processor.ts b/core/src/agents/processors/request_confirmation_llm_request_processor.ts
index 6d607ec7..bff4d1a9 100644
--- a/core/src/agents/processors/request_confirmation_llm_request_processor.ts
+++ b/core/src/agents/processors/request_confirmation_llm_request_processor.ts
@@ -26,7 +26,15 @@ import {BaseLlmRequestProcessor} from './base_llm_processor.js';
  * corresponding tools before the next LLM turn.
  */
 export class RequestConfirmationLlmRequestProcessor extends BaseLlmRequestProcessor {
-  /** Handles tool confirmation information to build the LLM request. */
+  /**
+   * Resumes tool calls that were paused for user confirmation, re-invoking
+   * them with the confirmed or denied decision before the next LLM turn.
+   *
+   * @param invocationContext - The current invocation context, including the
+   *   session event history used to locate pending confirmation responses.
+   * @yields Function response events for tools that have been confirmed and
+   *   are ready to resume.
+   */
   override async *runAsync(
     invocationContext: InvocationContext,
   ): AsyncGenerator<Event, void, void> {