Tighten generics

[davidmorgan]

e.g. making replace taking an Iterable and having a separate method replaceFrom.

It's a breaking API change, so we likely want to do all related improvements in one shot.

[dowski]

Does this apply to all replace methods, e.g. this one on MapBuilder?

built_collection.dart/lib/src/map/map_builder.dart

Line 40 in 8153cc4

void replace(Object map) {

I got hit a runtime crash the other day b/c Object is so permissive.

[davidmorgan]

Map.replace is a slightly different case; there is no common superinterface between BuiltMap and Map, so the only way to accept either is to accept Object.

Possible ways forward: 1) get the SDK to add some superinterface e.g. HasEntries<K, V>; 2) add a lint that checks you pass only Map or BuiltMap; 3) change the API to have separate methods for accepting Map and BuiltMap.

I'll look at this when I get to looking at the other breaking changes, so this is the right issue for it.

Thanks.