feat: port googleauth from multi_json to standard lib json#575
Merged
Conversation
quartzmo
force-pushed
the
migrate-to-stdlib-json
branch
from
562ca5e to
6707008
Compare
aandreassa
approved these changes
Jun 4, 2026
aandreassa
left a comment
aandreassa
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for all your work
quartzmo
added a commit
to googleapis/signet
that referenced
this pull request
Jun 4, 2026
* Wrap JSON::ParserError in Signet::ParseError in parse_credentials. * signet is now guaranteed to use the standard library JSON engine natively, providing absolute consistency regardless of user configurations. * Remove multi_json's possible dispatch overhead and lock/mutex contention. * Slightly reduce overall memory footprint per request. * Tests were previously already using the json gem. * Remove multi_json runtime dependency from gemspec. refs: googleapis/google-auth-library-ruby#572 refs: googleapis/google-auth-library-ruby#575 fixes: #272
panterch
added a commit
to panterch/future_kids
that referenced
this pull request
Jun 4, 2026
- ruby-vips: required by image_processing/Active Storage for variant transforms, triggered by new browser specs that render pages with image attachments - multi_json: workaround for googleauth 1.17.0 bug where the gem was removed from the gemspec but require calls remain in the source code (googleapis/google-auth-library-ruby#575) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This change has broken the I think it should be fixed there, not here, but mentioning it for visability. |
panterch
added a commit
to panterch/future_kids
that referenced
this pull request
Jun 4, 2026
- ruby-vips: required by image_processing/Active Storage for variant transforms, triggered by new browser specs that render pages with image attachments - multi_json: workaround for googleauth 1.17.0 bug where the gem was removed from the gemspec but require calls remain in the source code (googleapis/google-auth-library-ruby#575) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
quartzmo
added a commit
to googleapis/google-api-ruby-client
that referenced
this pull request
Jun 8, 2026
…representable (#26612) * multi_json was removed from upstream dependencies googleauth (googleapis/google-auth-library-ruby#575) and signet (googleapis/signet#273). * representable documents that if you use representable/json, you must include multi_json in your own dependencies. * Fix CI loading of local changes to google-apis-core. * Run rubocop -a to reformat and sort google-apis-core.gemspec. fixes: #26611 fixes: #26613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
natively, providing absolute consistency regardless of user configurations.
fixes: #572