Skip to content

feat: migrate from multi_json to standard json#273

Merged
quartzmo merged 5 commits into
googleapis:mainfrom
quartzmo:multijson-to-json
Jun 4, 2026
Merged

feat: migrate from multi_json to standard json#273
quartzmo merged 5 commits into
googleapis:mainfrom
quartzmo:multijson-to-json

Conversation

@quartzmo

@quartzmo quartzmo commented Jun 2, 2026

Copy link
Copy Markdown
Member
  • Replace MultiJson.dump with JSON.generate in client serializers.
  • Replace MultiJson with JSON in test and spec suites.
  • Wrap JSON::ParserError in Signet::ParseError in parse_credentials.
  • Remove multi_json runtime dependency from gemspec.
  • signet is now guaranteed to use the standard library JSON engine
    natively, providing absolute consistency regardless of user configurations.
  • Remove multi_json's possible dispatch overhead and lock/mutex contention.
  • Slightly reduce overall memory footprint per request.
  • Tests under multi_json already used the json gem.

refs: googleapis/google-auth-library-ruby#572
refs: googleapis/google-auth-library-ruby#575

fixes: #272

@quartzmo quartzmo requested a review from a team as a code owner June 2, 2026 22:01
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2026
@quartzmo quartzmo merged commit bd067b2 into googleapis:main Jun 4, 2026
15 checks passed
@quartzmo quartzmo deleted the multijson-to-json branch June 4, 2026 16:21
@release-please release-please Bot mentioned this pull request Jun 4, 2026
Merged
@quartzmo quartzmo mentioned this pull request Jun 8, 2026
Merged
quartzmo added a commit to googleapis/google-api-ruby-client that referenced this pull request Jun 8, 2026
@quartzmo
fix(google-apis-core): Add missing multi_json runtime dependency for …
16afc11 
…representable (#26612)

* multi_json was removed from upstream dependencies googleauth (googleapis/google-auth-library-ruby#575) and signet (googleapis/signet#273).
* representable documents that if you use representable/json, you must include multi_json in your own dependencies.
* Fix CI loading of local changes to google-apis-core.
* Run rubocop -a to reformat and sort google-apis-core.gemspec.

fixes: #26611
fixes: #26613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aandreassa aandreassa aandreassa approved these changes

Assignees

No one assigned

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated constant MultiJson

2 participants

@quartzmo @aandreassa