-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for unfinalized appendable objects #720
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Type
Fields
Give feedbackNo fields configured for issues without a type.
To support unfinalized appendable objects in the testbench, the blob (metadata size, media, etc) needs to be updated in the database within
Upload.process_bidi_write_object_grpc, which mainly handles the bidi write business logic.Below is an example of how
blob.mediaandblob.metadata.sizecould be updated to the database. This would support test cases where size or data needs to read back for unfinalized appendable objects.Testbench implementaton details should be decided based on the internal design doc and needed test cases.
storage-testbench/gcs/upload.py
Lines 504 to 507 in 9a8ca66